Re: [PATCH 2/2] mac80211: minstrel try all rates

Adam Wozniak
2009-11-24T17:17:23Z

Johannes Berg wrote:
> I really don't like this patch anyhow though, it's at best a hackish
> workaround around an issue that should just be fixed instead.
>
> Will take another look at the other patch tomorrow.
>
I concur 2/2 is a hack. I'm not an 802.11 ad-hoc expert, and I haven't
been allocated time to pursue the issue any more deeply than this. It
is still not clear to me how the list of usable rates is supposed to be
determined when the IBSS is composed of stations with heterogeneous rate
capabilities, beaconing is stochastically distributed, and not all nodes
can hear all beacons, much less what is wrong with the way the current
code is doing it.

I do not believe 1/2 was a hack. It really was possible to get to the
end of that function and use that variable without it being assigned the
correct value. Also, it is important to reinitialize the rate control
layer when the list of usable rates changes.

I would certainly be in favor of a better patch that resolves all the
issues.

--Adam Wozniak