Re: [PATCH 2/2] mac80211: minstrel try all rates

Johannes Berg
2009-11-24T18:37:27Z

[-- Attachment #1: Type: text/plain, Size: 837 bytes --]

On Tue, 2009-11-24 at 10:34 -0800, Adam Wozniak wrote:
> Johannes Berg wrote:
> > Or you can probably call rate_exit and rate_init but I don't know how
> > the algorithms would react if you actually ask it for a rate during that
> > race window?
> >
> There is no rate_exit in rate_control_ops, only init and update. There
> is an rc80211_minstrel_exit() in rc80211_minstrel.c, but that just
> unregisters the module, which I don't think is what you want.

Hah, indeed, I thought it was symmetric, guess it's not.

However, that reminds me that I actually wanted to get rid of
rate_init() since it's mostly not useful to have it separate from
alloc_sta()... oh well.

I suppose if we document clearly that rate_init maybe called multiple
times and audit the existing algorithms the patch could be ok.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]