Re: [PATCH 2/2] mac80211: minstrel try all rates

Johannes Berg
2009-11-24T17:59:05Z

[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]

On Tue, 2009-11-24 at 09:55 -0800, Adam Wozniak wrote:
> Johannes Berg wrote:
> > On Tue, 2009-11-24 at 09:17 -0800, Adam Wozniak wrote:
> >
> >> I do not believe 1/2 was a hack. It really was possible to get to the
> >> end of that function and use that variable without it being assigned the
> >> correct value. Also, it is important to reinitialize the rate control
> >> layer when the list of usable rates changes.
> >>
> > Ah, indeed. But I still don't think the rate control _init() function
> > should be called again.
> >
> My first thought was to use rate_control_ops.rate_update (via rate.h's
> rate_control_rate_update() function).
>
> However, neither minstrel nor pid_algo implement it, and the only place
> it is actually used is from ieee80211_enable_ht() (in mlme.c) when the
> channel type changes.
>
> So the only way (currently) to "update" is call _init() again.

I think I'd rather require that they implement it then, and add a new
flag that says "got new info on supported rates".

Or you can probably call rate_exit and rate_init but I don't know how
the algorithms would react if you actually ask it for a rate during that
race window?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]