Re: [PATCH 2/2] mac80211: minstrel try all rates

Johannes Berg
2009-11-24T01:11:36Z

[-- Attachment #1: Type: text/plain, Size: 1266 bytes --]

On Mon, 2009-11-23 at 16:57 -0800, Adam Wozniak wrote:
> In Ad-Hoc mode, it is possible for minstrel to be initialized without
> complete rate information. In these cases, throughput suffers because
> not all rates are tried. This patch tells minstrel to try all rates.
> This won't cause problems, because unsupported rates will simply fail,
> causing minstrel to set their probability to 0%.

Both your patches are completely whitespace damaged.

I really don't like this patch anyhow though, it's at best a hackish
workaround around an issue that should just be fixed instead.

Will take another look at the other patch tomorrow.

johannes

> Signed-off-by: Adam Wozniak <awozniak@irobot.com>
> ---
> diff --git a/net/mac80211/rc80211_minstrel.c
> b/net/mac80211/rc80211_minstrel.c
> index 6e5d68b..3a8fe30 100644
> --- a/net/mac80211/rc80211_minstrel.c
> +++ b/net/mac80211/rc80211_minstrel.c
> @@ -395,8 +395,6 @@ minstrel_rate_init(void *priv, struct
> ieee80211_supported_band *sband,
> unsigned int tx_time_single;
> unsigned int cw = mp->cw_min;
>
> - if (!rate_supported(sta, sband->band, i))
> - continue;
> n++;
> memset(mr, 0, sizeof(*mr));
>
>
>

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]