Re: compat-wireless and minstrel

Adam Wozniak
2009-11-16T17:25:56Z

If we have only three stations in an ad-hoc network, where all three can
hear the other two, only one of them should be beaconing, correct? If
this is true, it's not clear to me how the non beaconing stations will
update their rate information about each other based on the beacon. It
seems like, in the case we're "absent other information", we also need
to send a probe request, OR we need to get the bitrate information from
the next probe request we receive from them (neither of which we seem to
be doing).

Johannes Berg wrote:
> On Fri, 2009-11-13 at 14:35 -0800, Adam Wozniak wrote:
>
>
>> I've traced it down to this bit in rx.c in prepare_for_handlers():
>>
>> case NL80211_IFTYPE_ADHOC:
>> [ stuff deleted ]
>> } else if (!rx->sta) {
>> int rate_idx;
>> if (rx->status->flag & RX_FLAG_HT)
>> rate_idx = 0; /* TODO: HT rates */
>> else
>> rate_idx = rx->status->rate_idx;
>>
>> rx->sta = ieee80211_ibss_add_sta(sdata, bssid,
>> hdr->addr2,
>> BIT(rate_idx));
>> }
>> break;
>>
>> I don't think this is right. I know the issue is here, because if I
>> change to "BIT(rate_idx) | 0xfff" the problem corrects. Either we need
>> to (a) set it properly here or (b) make sure something else happens
>> before or after. I'm not sure we have enough context here to do (a).
>>
>
> Hmm. This BIT(..) was basically here to ensure we have at least a single
> good rate absent other information. If we do not receive a probe or
> beacon frame from that peer at least once, but add it to our IBSS only
> due to a single received data frame, we add the bitrate that this frame
> was transmitted at so we have one rate that we know it can transmit (and
> presumably also receive).
>
> What should happen is that once it starts beaconing we pick up a beacon
> and extend our set of known good rates.
>
> johannes
>