* (no subject)
@ 2009-11-18 1:50 Janakiram Sistla
2009-11-18 2:25 ` Janakiram Sistla
2009-11-18 10:53 ` Re: Johannes Berg
0 siblings, 2 replies; 7+ messages in thread
From: Janakiram Sistla @ 2009-11-18 1:50 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Janakiram Sistla
From: Janakiram Sistla <janakiram.sistla@gmail.com>
Adding radio type FM in RFKILL_TYPE_.FM belongs to
same class of with both TX/RX capability
Signed-off-by: Janakiram Sistla <janakiram.sistla@gmail.com>
---
include/linux/rfkill.h | 2 ++
net/rfkill/core.c | 2 ++
2 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
index 3392c59..7ae75ef 100644
--- a/include/linux/rfkill.h
+++ b/include/linux/rfkill.h
@@ -35,6 +35,7 @@
* @RFKILL_TYPE_UWB: switch is on a ultra wideband device.
* @RFKILL_TYPE_WIMAX: switch is on a WiMAX device.
* @RFKILL_TYPE_WWAN: switch is on a wireless WAN device.
+ * @RFKILL_TYPE_FM: switch is on a wireless FM device.
* @NUM_RFKILL_TYPES: number of defined rfkill types
*/
enum rfkill_type {
@@ -44,6 +45,7 @@ enum rfkill_type {
RFKILL_TYPE_UWB,
RFKILL_TYPE_WIMAX,
RFKILL_TYPE_WWAN,
+ RFKILL_TYPE_FM,
RFKILL_TYPE_GPS,
NUM_RFKILL_TYPES,
};
diff --git a/net/rfkill/core.c b/net/rfkill/core.c
index ba2efb9..61b716e 100644
--- a/net/rfkill/core.c
+++ b/net/rfkill/core.c
@@ -590,6 +590,8 @@ static const char *rfkill_get_type_str(enum rfkill_type type)
return "wimax";
case RFKILL_TYPE_WWAN:
return "wwan";
+ case RFKILL_TYPE_FM:
+ return "fm";
case RFKILL_TYPE_GPS:
return "gps";
default:
--
1.5.4.3
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re:
2009-11-18 1:50 Janakiram Sistla
@ 2009-11-18 2:25 ` Janakiram Sistla
2009-11-18 10:53 ` Re: Johannes Berg
1 sibling, 0 replies; 7+ messages in thread
From: Janakiram Sistla @ 2009-11-18 2:25 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Janakiram Sistla
I will be resending this patch ...sorry subjet line missing in this
sorry about that
Regards,
Ram.
On Wed, Nov 18, 2009 at 7:20 AM, Janakiram Sistla
<janakiram.sistla@gmail.com> wrote:
> From: Janakiram Sistla <janakiram.sistla@gmail.com>
>
> Adding radio type FM in RFKILL_TYPE_.FM belongs to
> same class of with both TX/RX capability
>
> Signed-off-by: Janakiram Sistla <janakiram.sistla@gmail.com>
> ---
> include/linux/rfkill.h | 2 ++
> net/rfkill/core.c | 2 ++
> 2 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
> index 3392c59..7ae75ef 100644
> --- a/include/linux/rfkill.h
> +++ b/include/linux/rfkill.h
> @@ -35,6 +35,7 @@
> * @RFKILL_TYPE_UWB: switch is on a ultra wideband device.
> * @RFKILL_TYPE_WIMAX: switch is on a WiMAX device.
> * @RFKILL_TYPE_WWAN: switch is on a wireless WAN device.
> + * @RFKILL_TYPE_FM: switch is on a wireless FM device.
> * @NUM_RFKILL_TYPES: number of defined rfkill types
> */
> enum rfkill_type {
> @@ -44,6 +45,7 @@ enum rfkill_type {
> RFKILL_TYPE_UWB,
> RFKILL_TYPE_WIMAX,
> RFKILL_TYPE_WWAN,
> + RFKILL_TYPE_FM,
> RFKILL_TYPE_GPS,
> NUM_RFKILL_TYPES,
> };
> diff --git a/net/rfkill/core.c b/net/rfkill/core.c
> index ba2efb9..61b716e 100644
> --- a/net/rfkill/core.c
> +++ b/net/rfkill/core.c
> @@ -590,6 +590,8 @@ static const char *rfkill_get_type_str(enum rfkill_type type)
> return "wimax";
> case RFKILL_TYPE_WWAN:
> return "wwan";
> + case RFKILL_TYPE_FM:
> + return "fm";
> case RFKILL_TYPE_GPS:
> return "gps";
> default:
> --
> 1.5.4.3
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re:
2009-11-18 1:50 Janakiram Sistla
2009-11-18 2:25 ` Janakiram Sistla
@ 2009-11-18 10:53 ` Johannes Berg
2009-11-18 11:31 ` Re: Janakiram Sistla
2009-11-18 13:44 ` Re: John W. Linville
1 sibling, 2 replies; 7+ messages in thread
From: Johannes Berg @ 2009-11-18 10:53 UTC (permalink / raw)
To: Janakiram Sistla; +Cc: linville, linux-wireless
[-- Attachment #1: Type: text/plain, Size: 979 bytes --]
On Wed, 2009-11-18 at 07:20 +0530, Janakiram Sistla wrote:
> ---
> include/linux/rfkill.h | 2 ++
> net/rfkill/core.c | 2 ++
> 2 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
> index 3392c59..7ae75ef 100644
> --- a/include/linux/rfkill.h
> +++ b/include/linux/rfkill.h
> @@ -35,6 +35,7 @@
> * @RFKILL_TYPE_UWB: switch is on a ultra wideband device.
> * @RFKILL_TYPE_WIMAX: switch is on a WiMAX device.
> * @RFKILL_TYPE_WWAN: switch is on a wireless WAN device.
> + * @RFKILL_TYPE_FM: switch is on a wireless FM device.
> * @NUM_RFKILL_TYPES: number of defined rfkill types
> */
> enum rfkill_type {
> @@ -44,6 +45,7 @@ enum rfkill_type {
> RFKILL_TYPE_UWB,
> RFKILL_TYPE_WIMAX,
> RFKILL_TYPE_WWAN,
> + RFKILL_TYPE_FM,
> RFKILL_TYPE_GPS,
> NUM_RFKILL_TYPES,
> };
Nice try, but no fly. This struct is ABI, you cannot add in the middle.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re:
2009-11-18 10:53 ` Re: Johannes Berg
@ 2009-11-18 11:31 ` Janakiram Sistla
2009-11-18 13:44 ` Re: John W. Linville
1 sibling, 0 replies; 7+ messages in thread
From: Janakiram Sistla @ 2009-11-18 11:31 UTC (permalink / raw)
To: Johannes Berg; +Cc: linville, linux-wireless
On Wed, Nov 18, 2009 at 4:23 PM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> On Wed, 2009-11-18 at 07:20 +0530, Janakiram Sistla wrote:
>
>> ---
>> include/linux/rfkill.h | 2 ++
>> net/rfkill/core.c | 2 ++
>> 2 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
>> index 3392c59..7ae75ef 100644
>> --- a/include/linux/rfkill.h
>> +++ b/include/linux/rfkill.h
>> @@ -35,6 +35,7 @@
>> * @RFKILL_TYPE_UWB: switch is on a ultra wideband device.
>> * @RFKILL_TYPE_WIMAX: switch is on a WiMAX device.
>> * @RFKILL_TYPE_WWAN: switch is on a wireless WAN device.
>> + * @RFKILL_TYPE_FM: switch is on a wireless FM device.
>> * @NUM_RFKILL_TYPES: number of defined rfkill types
>> */
>> enum rfkill_type {
>> @@ -44,6 +45,7 @@ enum rfkill_type {
>> RFKILL_TYPE_UWB,
>> RFKILL_TYPE_WIMAX,
>> RFKILL_TYPE_WWAN,
>> + RFKILL_TYPE_FM,
>> RFKILL_TYPE_GPS,
>> NUM_RFKILL_TYPES,
>> };
>
> Nice try, but no fly. This struct is ABI, you cannot add in the middle.
Is it ok if i can add my change after RFKILL_TYPE_GPS.But with respect
to the change i made i also made the necessary changes in core.c.
>
> johannes
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re:
2009-11-18 10:53 ` Re: Johannes Berg
2009-11-18 11:31 ` Re: Janakiram Sistla
@ 2009-11-18 13:44 ` John W. Linville
2009-11-18 14:19 ` Re: Janakiram Sistla
1 sibling, 1 reply; 7+ messages in thread
From: John W. Linville @ 2009-11-18 13:44 UTC (permalink / raw)
To: Johannes Berg; +Cc: Janakiram Sistla, linux-wireless
On Wed, Nov 18, 2009 at 11:53:51AM +0100, Johannes Berg wrote:
> On Wed, 2009-11-18 at 07:20 +0530, Janakiram Sistla wrote:
>
> > ---
> > include/linux/rfkill.h | 2 ++
> > net/rfkill/core.c | 2 ++
> > 2 files changed, 4 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
> > index 3392c59..7ae75ef 100644
> > --- a/include/linux/rfkill.h
> > +++ b/include/linux/rfkill.h
> > @@ -35,6 +35,7 @@
> > * @RFKILL_TYPE_UWB: switch is on a ultra wideband device.
> > * @RFKILL_TYPE_WIMAX: switch is on a WiMAX device.
> > * @RFKILL_TYPE_WWAN: switch is on a wireless WAN device.
> > + * @RFKILL_TYPE_FM: switch is on a wireless FM device.
> > * @NUM_RFKILL_TYPES: number of defined rfkill types
> > */
> > enum rfkill_type {
> > @@ -44,6 +45,7 @@ enum rfkill_type {
> > RFKILL_TYPE_UWB,
> > RFKILL_TYPE_WIMAX,
> > RFKILL_TYPE_WWAN,
> > + RFKILL_TYPE_FM,
> > RFKILL_TYPE_GPS,
> > NUM_RFKILL_TYPES,
> > };
>
> Nice try, but no fly. This struct is ABI, you cannot add in the middle.
Ah, good point -- I think I may have inadvertently encourage this
order. :-(
It looks like you'll need the other order -- be mindful of the
BUILD_BUG_ON I pointed-out in the previous email!
John
P.S. Hmmm...anyone want to add a kerneldoc entry for RFKILL_TYPE_GPS?
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re:
2009-11-18 13:44 ` Re: John W. Linville
@ 2009-11-18 14:19 ` Janakiram Sistla
2009-11-18 14:45 ` Re: John W. Linville
0 siblings, 1 reply; 7+ messages in thread
From: Janakiram Sistla @ 2009-11-18 14:19 UTC (permalink / raw)
To: John W. Linville; +Cc: Johannes Berg, linux-wireless
On Wed, Nov 18, 2009 at 7:14 PM, John W. Linville
<linville@tuxdriver.com> wrote:
> On Wed, Nov 18, 2009 at 11:53:51AM +0100, Johannes Berg wrote:
>> On Wed, 2009-11-18 at 07:20 +0530, Janakiram Sistla wrote:
>>
>> > ---
>> > include/linux/rfkill.h | 2 ++
>> > net/rfkill/core.c | 2 ++
>> > 2 files changed, 4 insertions(+), 0 deletions(-)
>> >
>> > diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
>> > index 3392c59..7ae75ef 100644
>> > --- a/include/linux/rfkill.h
>> > +++ b/include/linux/rfkill.h
>> > @@ -35,6 +35,7 @@
>> > * @RFKILL_TYPE_UWB: switch is on a ultra wideband device.
>> > * @RFKILL_TYPE_WIMAX: switch is on a WiMAX device.
>> > * @RFKILL_TYPE_WWAN: switch is on a wireless WAN device.
>> > + * @RFKILL_TYPE_FM: switch is on a wireless FM device.
>> > * @NUM_RFKILL_TYPES: number of defined rfkill types
>> > */
>> > enum rfkill_type {
>> > @@ -44,6 +45,7 @@ enum rfkill_type {
>> > RFKILL_TYPE_UWB,
>> > RFKILL_TYPE_WIMAX,
>> > RFKILL_TYPE_WWAN,
>> > + RFKILL_TYPE_FM,
>> > RFKILL_TYPE_GPS,
>> > NUM_RFKILL_TYPES,
>> > };
>>
>> Nice try, but no fly. This struct is ABI, you cannot add in the middle.
>
> Ah, good point -- I think I may have inadvertently encourage this
> order. :-(
>
> It looks like you'll need the other order -- be mindful of the
> BUILD_BUG_ON I pointed-out in the previous email!
>
> John
>
> P.S. Hmmm...anyone want to add a kerneldoc entry for RFKILL_TYPE_GPS?
Can i add this ???
> --
> John W. Linville Someday the world will need a hero, and you
> linville@tuxdriver.com might be all we have. Be ready.
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re:
2009-11-18 14:19 ` Re: Janakiram Sistla
@ 2009-11-18 14:45 ` John W. Linville
0 siblings, 0 replies; 7+ messages in thread
From: John W. Linville @ 2009-11-18 14:45 UTC (permalink / raw)
To: Janakiram Sistla; +Cc: Johannes Berg, linux-wireless
On Wed, Nov 18, 2009 at 07:49:30PM +0530, Janakiram Sistla wrote:
> On Wed, Nov 18, 2009 at 7:14 PM, John W. Linville
> > P.S. Hmmm...anyone want to add a kerneldoc entry for RFKILL_TYPE_GPS?
> Can i add this ???
Sure, but please do a different patch for that. Make it the first
one, so that it can be applied even if there is still a problem with
the other patch.
Thanks,
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2009-11-18 15:00 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-18 1:50 Janakiram Sistla
2009-11-18 2:25 ` Janakiram Sistla
2009-11-18 10:53 ` Re: Johannes Berg
2009-11-18 11:31 ` Re: Janakiram Sistla
2009-11-18 13:44 ` Re: John W. Linville
2009-11-18 14:19 ` Re: Janakiram Sistla
2009-11-18 14:45 ` Re: John W. Linville
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).