Re: [RFC] p54: software hot-swap eeprom image

[Dan Williams <dcbw@redhat.com>]

On Fri, 2009-11-20 at 22:24 +0200, Kalle Valo wrote:
> Christian Lamparter <chunkeey@googlemail.com> writes:
> 
> > This (aggregated) patch adds a new sysfs file "eeprom_overwrite"
> > which can be used to upload an customized eeprom image to the
> > driver during normal operation.
> >
> > The old wlanX device will quickly vanish. And if the new EEPROM
> > image passes all sanity checks the device will reappear.
> >
> > Hopefully, this proves to be an adequate solution for everyone
> > with a bad/missing EEPROM data/chip.
> 
> Wasn't the concensus that request_firmware() will be used for this
> kind of device specific data? stlc45xx had a similar sysfs interface
> and people didn't like it. And I tend to agree with them, adding odd
> sysfs files is not the best way to handle this.

It could be yes, but what would the trigger to upload the new firmware
be?  A /standard/ sysfs file that you

echo "new-firmware-v345" > eeprom_write

into that would then request_firmware("new-firmware-v345")?  I don't
really care where read/write functionality is, I just want this stuff to
be in one place and not have one mechanism for reading it and a few
different ones for writing it.

Dan