public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Maxim Levitsky <maximlevitsky@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2.6.32] rfkill: fix miscdev ops
Date: Mon, 23 Nov 2009 12:44:42 +0200	[thread overview]
Message-ID: <1258973082.3675.0.camel@maxim-laptop> (raw)
In-Reply-To: <1258972050.7094.140.camel@johannes.local>

On Mon, 2009-11-23 at 11:27 +0100, Johannes Berg wrote: 
> The /dev/rfkill ops don't refer to the module,
> so it is possible to unload the module while
> file descriptors are open. Fix this oversight.
> 
> Reported-by: Maxim Levitsky <maximlevitsky@gmail.com>
> Cc: stable@kernel.org
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> ---
>  net/rfkill/core.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- wireless-testing.orig/net/rfkill/core.c	2009-11-23 11:11:13.000000000 +0100
> +++ wireless-testing/net/rfkill/core.c	2009-11-23 11:11:59.000000000 +0100
> @@ -1191,6 +1191,7 @@ static long rfkill_fop_ioctl(struct file
>  #endif
>  
>  static const struct file_operations rfkill_fops = {
> +	.owner		= THIS_MODULE,
>  	.open		= rfkill_fop_open,
>  	.read		= rfkill_fop_read,
>  	.write		= rfkill_fop_write,
> 
> 

Thanks for the quick patch!, works fine.

Best regards,
Maxim Levitsky


  reply	other threads:[~2009-11-23 10:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-23  9:28 RFKILL related oops on iwl3945 reload Maxim Levitsky
2009-11-23 10:27 ` [PATCH 2.6.32] rfkill: fix miscdev ops Johannes Berg
2009-11-23 10:44   ` Maxim Levitsky [this message]
2009-11-23 10:49     ` Johannes Berg
2009-11-23 14:12       ` Maxim Levitsky
2009-11-23 16:00         ` Johannes Berg
2009-11-23 17:16       ` iwl3945 dies on module reload Maxim Levitsky
2009-11-23 23:24         ` [ipw3945-devel] " Cahill, Ben M
2009-11-23 23:54           ` Maxim Levitsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1258973082.3675.0.camel@maxim-laptop \
    --to=maximlevitsky@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox