Re: [PATCH] mwl8k: split driver by chipset

Julian Calaby
2009-11-23T07:54:12Z

On Mon, Nov 23, 2009 at 10:05, Dan Williams <dcbw@redhat.com> wrote:
> No functional changes, but split the code up to make it
> easier to add support for other Libertas softmac chipsets
> like the 88w8361, which has slightly different RX and TX
> descriptors and some slightly different commands.
>
> Signed-off-by: Dan Williams <dcbw@redhat.com>

Yay, potential 88w8335 support!

> ---
> Note: patch is large (code reshuffle) so in case it gets rejected:
>
> http://bigw.org/~dan/mwl8k-split.patch

Diffstat?

> diff --git a/drivers/net/wireless/mwl8k/Kconfig b/drivers/net/wireless/mwl8k/Kconfig
> new file mode 100644
> index 0000000..48b4071
> --- /dev/null
> +++ b/drivers/net/wireless/mwl8k/Kconfig
> @@ -0,0 +1,29 @@
> +config MWL8K_COMMON
> +       tristate "Marvell 88W8xxx PCI/PCIe Wireless support"
> +       depends on MAC80211 && PCI && WLAN_80211 && EXPERIMENTAL
> +       ---help---
> +         This is common code for Marvell TOPDOG 802.11 wireless cards.  This
> +         module does nothing by itself - the device-specific front-ends
> +         also need to be enabled in order to support any devices.
> +
> +         To compile this driver as a module, choose M here: the module
> +         will be called mwl8k.  If unsure, say N.
> +
> +config MWL8687
> +       tristate "Marvell 88W8687 PCI/PCIe Wireless support"
> +       depends on MWL8K_COMMON
> +       ---help---
> +         This driver is for Marvell TOPDOG 88w8687-based wireless cards.
> +
> +         To compile this driver as a module, choose M here: the module
> +         will be called mwl8687.  If unsure, say N.
> +
> +config MWL8366
> +       tristate "Marvell 88W8366 PCI/PCIe Wireless support"
> +       depends on MWL8K_COMMON
> +       ---help---
> +         This driver is for Marvell TOPDOG 88w8366-based wireless cards.
> +
> +         To compile this driver as a module, choose M here: the module
> +         will be called mwl8366.  If unsure, say N.
> +

Isn't there a menuconfig option that'd make the depends on
MWL8K_COMMON redundant?

Thanks,

--

Julian Calaby

Email: julian.calaby@gmail.com
.Plan: http://sites.google.com/site/juliancalaby/