Re: [PATCH] mwl8k: split driver by chipset

Johannes Berg
2009-11-23T11:13:10Z

[-- Attachment #1: Type: text/plain, Size: 1285 bytes --]

On Mon, 2009-11-23 at 12:02 +0100, Lennert Buytenhek wrote:

> I was wondering if we should really make the support for each chip a
> different kernel module as you did in your patch, but then I figured
> that this might be a good way to let the user choose whether to load
> AP or STA firmware if we have both available, which was still one of
> the unsolved problems. I.e., make mwl8366_ap and mwl8366_sta, and
> then let the user choose which one to load. Or is there a better way
> of doing this?

Try to load both at probe() time (via the async firmware loading
interface that I fixed up recently [1], that patch will be in .33), and
hang on to the firmware images [2]. Register the wiphy with appropriate
bits depending on which firmware files you found (and fail + unbind if
you didn't find any, cf. my ar9170 patch [3]). Then you can upload the
right firmware depending on the type of interface the user is adding.

(Maybe, if needed for EMBEDDED, allow the user to configure which
firmware you load.)

johannes

[1] http://johannes.sipsolutions.net/patches/kernel/all/LATEST/NNN-firmware-class-nowait.patch
[2] that is what my patch allows doing
[3] http://johannes.sipsolutions.net/patches/kernel/all/LATEST/NNN-ar9170-firmware-request-async.patch

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]