Re: [RFC 1/2] wireless: add ieee80211_asmdu_to_8023s

Johannes Berg
2009-11-26T10:06:15Z

[-- Attachment #1: Type: text/plain, Size: 1019 bytes --]

On Thu, 2009-11-26 at 14:03 +0800, Zhu Yi wrote:

> --- a/include/net/cfg80211.h
> +++ b/include/net/cfg80211.h
> @@ -1593,6 +1593,18 @@ int ieee80211_data_from_8023(struct sk_buff *skb, u8 *addr,
> enum nl80211_iftype iftype, u8 *bssid, bool qos);
>
> /**
> + * ieee80211_asmdu_to_8023s - decode an IEEE 802.11n A-MSDU frame
> + *
> + * @skb: The input IEEE 802.11n A-MSDU frame.
> + * @list: The output list of 802.3 frames. It must be allocated and
> + * initialized by by the caller.
> + * @addr: The device MAC address.
> + * @iftype: The device interface type.
> + */
> +int ieee80211_amsdu_to_8023s(struct sk_buff *skb, struct sk_buff_head *list,
> + u8 *addr, enum nl80211_iftype iftype);

Oh one more thing, can you make addr const?

Also -- you lost the extra TX headroom which I think mac80211 as an AP
requires since it could forward these frames? Or does that not happen?
Not sure right now why that was there to start with.