From: Johannes Berg <johannes@sipsolutions.net>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Alan Jenkins <alan-jenkins@tuffmail.co.uk>,
Marcel Holtmann <marcel@holtmann.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Ian Molton <ian.molton@collabora.co.uk>,
linux-acpi@vger.kernel.org,
Corentin Chary <corentincj@iksaif.net>
Subject: Re: rfkill: persistent device suspend/resume
Date: Sat, 28 Nov 2009 14:39:49 +0100 [thread overview]
Message-ID: <1259415589.5428.22.camel@johannes.local> (raw)
In-Reply-To: <20091128132752.GD17373@khazad-dum.debian.net>
[-- Attachment #1: Type: text/plain, Size: 753 bytes --]
On Sat, 2009-11-28 at 11:27 -0200, Henrique de Moraes Holschuh wrote:
> > static int rfkill_resume(struct device *dev)
> > {
> > struct rfkill *rfkill = to_rfkill(dev);
> > bool cur;
> >
> > if (!rfkill->persistent) {
> > cur = !!(rfkill->state & RFKILL_BLOCK_SW);
> > rfkill_set_block(rfkill, cur);
> > }
>
> The issue I am reporting is _only_ about persistent devices, so it is the
> if(!rfkill->persistent) that is the problem. It works perfectly for the
> other devices.
So then I don't understand -- if the device specifically said that it
was persistent, what kind of help does it need, and why does it not just
unset persistent if it needs it?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2009-11-28 13:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-16 13:53 [PATCH 2/4] rfkill: don't restore software blocked state on persistent devices Alan Jenkins
2009-06-16 14:14 ` Johannes Berg
2009-06-16 14:39 ` [PATCHv2 " Alan Jenkins
2009-06-16 15:37 ` Marcel Holtmann
2009-06-18 3:08 ` Henrique de Moraes Holschuh
2009-11-28 12:41 ` rfkill: persistent device suspend/resume Henrique de Moraes Holschuh
2009-11-28 13:12 ` Johannes Berg
2009-11-28 13:27 ` Henrique de Moraes Holschuh
2009-11-28 13:39 ` Johannes Berg [this message]
2009-11-28 17:17 ` Henrique de Moraes Holschuh
2009-11-28 15:32 ` Alan Jenkins
2009-11-28 16:42 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259415589.5428.22.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=alan-jenkins@tuffmail.co.uk \
--cc=corentincj@iksaif.net \
--cc=hmh@hmh.eng.br \
--cc=ian.molton@collabora.co.uk \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).