From: Zhu Yi <yi.zhu@intel.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] iwmc3200wifi: rx aggregation support
Date: Mon, 30 Nov 2009 09:11:21 +0800 [thread overview]
Message-ID: <1259543481.12157.18.camel@debian> (raw)
In-Reply-To: <1259314800.5428.13.camel@johannes.local>
On Fri, 2009-11-27 at 17:40 +0800, Johannes Berg wrote:
> You did the right thing in mac80211, but not here -- if it returns an
> error it hasn't freed 'skb', only modified it.
Indeed.
> I think that we should have ieee80211_amsdu_to_8023s() consume it in
> all cases, just not fill the list (and return an error I guess) when
> it can't be decoded properly.
Yeah, since I didn't even use it correctly myself, I couldn't expect
others do. Besides, the nontransparent reuse of skb for the last item in
the list (skb == rx->skb) looks dirty. I'll use RX_QUEUED in v3.
Thanks,
-yi
next prev parent reply other threads:[~2009-11-30 1:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-27 3:18 [PATCH v2 1/2] wireless: add ieee80211_amsdu_to_8023s Zhu Yi
2009-11-27 3:18 ` [PATCH v2 2/2] iwmc3200wifi: rx aggregation support Zhu Yi
2009-11-27 9:40 ` Johannes Berg
2009-11-30 1:11 ` Zhu Yi [this message]
2009-11-30 3:56 ` Zhu Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259543481.12157.18.camel@debian \
--to=yi.zhu@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).