From: Johannes Berg <johannes@sipsolutions.net>
To: Zhu Yi <yi.zhu@intel.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3 1/2] wireless: add ieee80211_amsdu_to_8023s
Date: Mon, 30 Nov 2009 16:20:15 +0100 [thread overview]
Message-ID: <1259594415.32171.14.camel@johannes.local> (raw)
In-Reply-To: <1259555157-10866-1-git-send-email-yi.zhu@intel.com>
[-- Attachment #1: Type: text/plain, Size: 489 bytes --]
On Mon, 2009-11-30 at 12:25 +0800, Zhu Yi wrote:
> + __skb_queue_tail(list, frame);
> + }
> +
> + return 0;
> +
> + purge:
> + __skb_queue_purge(list);
> + out:
> + dev_kfree_skb(skb);
> + return -1;
I'm not sure there's much use in the return value, since it otherwise
leaves the list empty and you don't _really_ care all that much to
iterate an empty list in that case, but it doesn't really matter.
Acked-by: Johannes Berg <johannes@sipsolutions.net>
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
prev parent reply other threads:[~2009-11-30 15:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-30 4:25 [PATCH v3 1/2] wireless: add ieee80211_amsdu_to_8023s Zhu Yi
2009-11-30 4:25 ` [PATCH v3 2/2] iwmc3200wifi: rx aggregation support Zhu Yi
2009-11-30 16:16 ` Samuel Ortiz
2009-11-30 15:20 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259594415.32171.14.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox