From: Johannes Berg <johannes@sipsolutions.net>
To: Vasanthakumar Thiagarajan <vasanth@atheros.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
stable@kernel.org
Subject: Re: [PATCH] mac80211: Fix bug in computing crc over dynamic IEs in beacon
Date: Fri, 04 Dec 2009 13:29:58 +0100 [thread overview]
Message-ID: <1259929798.29974.0.camel@johannes.local> (raw)
In-Reply-To: <1259928694-7824-1-git-send-email-vasanth@atheros.com>
[-- Attachment #1: Type: text/plain, Size: 831 bytes --]
On Fri, 2009-12-04 at 17:41 +0530, Vasanthakumar Thiagarajan wrote:
> On a 32-bit machine, BIT() macro does not give the required
> bit value if the bit is mroe than 31.
For some reason I thought it did, thanks.
> In ieee802_11_parse_elems_crc(),
> BIT() is suppossed to get the bit value more than 31 (42 (id of ERP_INFO_IE),
> 37 (CHANNEL_SWITCH_IE), (42), 32 (POWER_CONSTRAINT_IE), 45 (HT_CAP_IE),
> 61 (HT_INFO_IE)). As we do not get the required bit value for the above
> IEs, crc over these IEs are never calculated, so any dynamic change in these
> IEs after the association is not really handled on 32-bit platforms.
> This patch fixes this issue.
Right. Note that this function may need to be changed/extended if we
ever need to watch for changes in even higher IEs, but so far we don't.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2009-12-04 12:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-04 12:11 [PATCH] mac80211: Fix bug in computing crc over dynamic IEs in beacon Vasanthakumar Thiagarajan
2009-12-04 12:29 ` Johannes Berg [this message]
2009-12-04 12:42 ` Vasanthakumar Thiagarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259929798.29974.0.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=stable@kernel.org \
--cc=vasanth@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).