Re: [PATCH 17/19] [RFC, v2] libertas: Kconfig entry for libertas+cfg80211

Johannes Berg
2009-10-23T14:19:32Z

[-- Attachment #1: Type: text/plain, Size: 611 bytes --]

On Thu, 2009-10-22 at 15:31 +0200, Holger Schurig wrote:

> +#ifdef CONFIG_LIBERTAS_WEXT
> dev->ethtool_ops = &lbs_ethtool_ops;
> dev->wireless_handlers = &lbs_handler_def;
> #endif

So here you make the wireless_handlers optional.

I still don't understand why you can't just replace only some of the
handlers, i.e. instead of doing this, simply do

- (iw_handler) lbs_set_freq, /* SIOCSIWFREQ */
+ (iw_handler) cfg80211_wext_siwfreq,

etc.

That's why those exist and are exported. And that way you don't need the
Kconfig at all, and can remove most of the wext code.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]