Re: [PATCH 17/19] [RFC, v2] libertas: Kconfig entry for libertas+cfg80211

Johannes Berg
2009-10-23T17:04:04Z

[-- Attachment #1: Type: text/plain, Size: 792 bytes --]

On Fri, 2009-10-23 at 09:52 -0700, Dan Williams wrote:

> > > Yeah, I think it's best to handle the mesh WEXT ioctls separately for
> > > now. There are really only 4 of them (get/set SSID, set channel, get
> > > mode) that matter for mesh. The rest of the ioctls that the mesh
> > > interface supports get redirected to the cfg80211 handlers because they
> > > aren't specific to mesh.
> >
> > So why can't we simply do
> >
> > set_ssid()
> > {
> > if (mesh)
> > return mesh_set_ssid();
> > else
> > return cfg80211_wext_iwessid()
> > }
>
> The mesh interface is a completely separate netdev, with its own WEXT
> handler struct. So we'd never be in that situation.

Ah right. Yes then it makes sense to just remove all the non-mesh WEXT
stuff.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]