From: Dan Williams <dcbw@redhat.com>
To: Stefan Seyfried <stefan.seyfried@googlemail.com>
Cc: Josua Dietze <digidietze@draisberghof.de>,
Matthew Dharm <mdharm-kernel@one-eyed-alien.net>,
Oliver Neukum <oliver@neukum.org>,
linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org,
usb-storage@lists.one-eyed-alien.net
Subject: Re: [PATCH] move eject code from zd1211rw to usb-storage
Date: Wed, 16 Dec 2009 08:47:17 -0800 [thread overview]
Message-ID: <1260982037.2179.5.camel@localhost.localdomain> (raw)
In-Reply-To: <20091216131452.49ad183b@strolchi.home.s3e.de>
On Wed, 2009-12-16 at 13:14 +0100, Stefan Seyfried wrote:
> On Wed, 16 Dec 2009 12:22:31 +0100
> Josua Dietze <digidietze@draisberghof.de> wrote:
>
> > Stefan Seyfried schrieb:
> > > Preferably some code that can be built actually?
> >
> > If the "eject" from SCSI tools does not work, "usb_modeswitch" can
> > send customized bulk messages to devices.
>
> for my device, eject seems to be enough, so I'll be trying to get
> this into udev.
>
> > http://www.draisberghof.de/usb_modeswitch/
>
> Unfortunately it cannot be built with current libusb and once you
> compile it without warnings turned off (which is the default!), you
> probably don't want to run it anymore ;)
At this point, however, usb_modeswitch is the correct place to put eject
code for all devices. I wouldn't put this code into udev; I'd put it
into usb_modeswitch instead, since usb_modeswitch is (a) the de-facto
standard, (b) has the most users, and (c) has the most devices. Yes, it
has problems, but at this point we should fix those problems instead of
creating 5 different eject tools.
Dan
next prev parent reply other threads:[~2009-12-16 16:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-15 12:06 [PATCH] move eject code from zd1211rw to usb-storage Stefan Seyfried
2009-12-15 12:31 ` Josua Dietze
2009-12-15 14:01 ` Stefan Seyfried
2009-12-15 14:59 ` Josua Dietze
2009-12-15 17:58 ` [usb-storage] " Matthew Dharm
2009-12-15 15:11 ` Oliver Neukum
2009-12-15 18:03 ` Matthew Dharm
2009-12-16 10:29 ` Oliver Neukum
2009-12-16 11:42 ` Josua Dietze
2009-12-16 18:03 ` Matthew Dharm
2009-12-16 19:50 ` Dan Williams
2009-12-16 19:52 ` Matthew Dharm
2009-12-17 13:02 ` Oliver Neukum
2009-12-17 13:33 ` Josua Dietze
2009-12-17 14:36 ` Oliver Neukum
2009-12-17 18:21 ` Matthew Dharm
2009-12-16 10:49 ` Stefan Seyfried
2009-12-16 11:22 ` Josua Dietze
2009-12-16 12:14 ` Stefan Seyfried
2009-12-16 14:05 ` John W. Linville
2009-12-16 16:47 ` Dan Williams [this message]
2009-12-16 19:12 ` Matthew Dharm
2009-12-16 11:23 ` Oliver Neukum
2009-12-17 10:41 ` [usb-storage] " Daniel Drake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1260982037.2179.5.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=digidietze@draisberghof.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mdharm-kernel@one-eyed-alien.net \
--cc=oliver@neukum.org \
--cc=stefan.seyfried@googlemail.com \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).