From: Gertjan van Wingerde <gwingerde@gmail.com>
To: "John W. Linville" <linville@tuxdriver.com>,
Wireless list <linux-wireless@vger.kernel.org>,
rt2x00 users list <users@rt2x00.serialmonkey.com>
Cc: Ivo van Doorn <ivdoorn@gmail.com>,
Gertjan van Wingerde <gwingerde@gmail.com>
Subject: [PATCH 5/6] rt2x00: Fix LED configuration setting for rt2800.
Date: Wed, 30 Dec 2009 11:36:33 +0100 [thread overview]
Message-ID: <1262169394-11647-6-git-send-email-gwingerde@gmail.com> (raw)
In-Reply-To: <1262169394-11647-5-git-send-email-gwingerde@gmail.com>
rt2800_blink_set uses an illegal value to set the LED_CFG_G_LED_MODE
field of the LED_CFG register. This field is only 2 bits large, so
should be initialized with value that fits. Use default value from
the vendor driver.
Signed-off-by: Gertjan van Wingerde <gwingerde@gmail.com>
---
drivers/net/wireless/rt2x00/rt2800lib.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
index 9a02589..ca700a4 100644
--- a/drivers/net/wireless/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/rt2x00/rt2800lib.c
@@ -358,7 +358,7 @@ static int rt2800_blink_set(struct led_classdev *led_cdev,
rt2x00_set_field32(®, LED_CFG_OFF_PERIOD, *delay_off);
rt2x00_set_field32(®, LED_CFG_SLOW_BLINK_PERIOD, 3);
rt2x00_set_field32(®, LED_CFG_R_LED_MODE, 3);
- rt2x00_set_field32(®, LED_CFG_G_LED_MODE, 12);
+ rt2x00_set_field32(®, LED_CFG_G_LED_MODE, 3);
rt2x00_set_field32(®, LED_CFG_Y_LED_MODE, 3);
rt2x00_set_field32(®, LED_CFG_LED_POLAR, 1);
rt2800_register_write(led->rt2x00dev, LED_CFG, reg);
--
1.6.6
next prev parent reply other threads:[~2009-12-30 10:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-30 10:36 [PATCH 0/6] rt2x00 fixes and cleanups Gertjan van Wingerde
2009-12-30 10:36 ` [PATCH 1/6] rt2x00: use correct headroom for transmission Gertjan van Wingerde
2009-12-30 10:36 ` [PATCH 2/6] rt2x00: Properly request tx headroom for alignment operations Gertjan van Wingerde
2009-12-30 10:36 ` [PATCH 3/6] rt2x00: RF3052 is a valid RF chipset for USB devices as well Gertjan van Wingerde
2009-12-30 10:36 ` [PATCH 4/6] rt2x00: Unify rt2800 WPDMA ready waiting functions Gertjan van Wingerde
2009-12-30 10:36 ` Gertjan van Wingerde [this message]
2009-12-30 10:36 ` [PATCH 6/6] rt2x00: Make rt2800_init_led static and don't export it Gertjan van Wingerde
2009-12-30 20:42 ` Ivo van Doorn
2009-12-30 20:42 ` [PATCH 5/6] rt2x00: Fix LED configuration setting for rt2800 Ivo van Doorn
2009-12-30 20:42 ` [PATCH 4/6] rt2x00: Unify rt2800 WPDMA ready waiting functions Ivo van Doorn
2009-12-30 20:41 ` [PATCH 3/6] rt2x00: RF3052 is a valid RF chipset for USB devices as well Ivo van Doorn
2009-12-30 20:41 ` [PATCH 1/6] rt2x00: use correct headroom for transmission Ivo van Doorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1262169394-11647-6-git-send-email-gwingerde@gmail.com \
--to=gwingerde@gmail.com \
--cc=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).