From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from bedivere.hansenpartnership.com ([66.63.167.143]:38380 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752755Ab0ABQe2 (ORCPT ); Sat, 2 Jan 2010 11:34:28 -0500 Subject: Re: regression: crash from 'ls /sys/modules/wl1251_spi/notes' From: James Bottomley To: =?ISO-8859-1?Q?Am=E9rico?= Wang Cc: Kalle Valo , linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, linux-omap@vger.kernel.org, Helge Deller , rusty@rustcorp.com.au, akpm@linux-foundation.org, roland@redhat.com, dave@hiauly1.hia.nrc.ca, Parisc List In-Reply-To: <2375c9f90912311908r667966e1m919430c40cd9c571@mail.gmail.com> References: <87k4w4wux9.fsf@purkki.valot.fi> <1262188157.2749.21.camel@mulgrave.site> <2375c9f90912311908r667966e1m919430c40cd9c571@mail.gmail.com> Content-Type: text/plain; charset="UTF-8" Date: Sat, 02 Jan 2010 10:34:22 -0600 Message-Id: <1262450062.2741.4.camel@mulgrave.site> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, 2010-01-01 at 11:08 +0800, Américo Wang wrote: > This patch looks fine for me, except that I don't think it's necessary > to introduce an inline function for that... Actually, I really think we do. The whole reason we got into this mess in the first place is that it wasn't obvious from the code that if we altered the loadability of sections, there were a ton of dependent places we also had to update. Putting all that knowledge into a single inline makes the same mistake impossible to make because there's now only one place to go to adjust the loadability of sections, and it automatically takes care of all the dependencies. > Reviewed-by: WANG Cong Thanks, James