From: Johannes Berg <johannes@sipsolutions.net>
To: Jouni Malinen <jouni.malinen@atheros.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, Jouni Malinen <j@w1.fi>
Subject: Re: [PATCH 1/3] mac80211: Select lowest rate based on basic rate set in AP mode
Date: Tue, 05 Jan 2010 10:29:30 +0100 [thread overview]
Message-ID: <1262683770.20098.12.camel@johannes.local> (raw)
In-Reply-To: <20091229105919.GB18493@jm.kir.nu>
[-- Attachment #1: Type: text/plain, Size: 546 bytes --]
On Tue, 2009-12-29 at 12:59 +0200, Jouni Malinen wrote:
> + if (basic_rates & (1 << *idx))
> + return; /* selected rate is a basic rate */
> +
> + for (i = *idx + 1; i <= max_rate_idx; i++) {
Starting at *idx+1 only works because it's always 0 or something?
Wouldn't you want to go down from max_rate and find the highest basic
rate or so?
Other than that seems fine to me, except I'm not sure I like the
"txrc.ap" thing much, but it's probably a reasonable choice to make at
this point (but consider mesh, IBSS?)
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2010-01-05 9:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-29 10:59 [PATCH 1/3] mac80211: Select lowest rate based on basic rate set in AP mode Jouni Malinen
2010-01-05 9:29 ` Johannes Berg [this message]
2010-01-05 17:45 ` Jouni Malinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1262683770.20098.12.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=j@w1.fi \
--cc=jouni.malinen@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox