Re: [PATCH] iwlwifi: remove IWLWIFI_VERSION

reinette chatre
2010-01-06T00:08:16Z

Hi John,

On Tue, 2010-01-05 at 13:54 -0800, John W. Linville wrote:
> Also remove the MODULE_VERSION macros using IWLWIFI_VERSION. Those
> places using IWLWIFI_VERSION at runtime are modified to use
> init_utsname()->release instead.
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> ---
> How about this as a compromise?

Thank you for looking at this.

I do think it is valuable for a user to see the parameters the module
was compiled with when running "modinfo". I thus would like the
MODULE_VERSION to stay. Including the kernel version number at runtime
seems fine. The version number display may be a bit strange when a user
did not compile with any of the options since the version number will
then end with "-".

Reinette