* [PATCH] firmware_class: remove base.h header inclusion
@ 2010-01-14 2:18 Luis R. Rodriguez
2010-01-14 5:16 ` Marcel Holtmann
0 siblings, 1 reply; 2+ messages in thread
From: Luis R. Rodriguez @ 2010-01-14 2:18 UTC (permalink / raw)
To: greg; +Cc: linux-wireless, linux-kernel, mcgrof, Luis R. Rodriguez,
Johannes Berg
base.h is used by base drivers for sharing internal structures.
Turns out firmware_class does not depend on it at all so remove it.
Cc: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
Spotted this while backporting firmware_class in compat.git.
Phew, firmware_class can be backported.
drivers/base/firmware_class.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
index a950241..8b1cfed 100644
--- a/drivers/base/firmware_class.c
+++ b/drivers/base/firmware_class.c
@@ -19,7 +19,6 @@
#include <linux/kthread.h>
#include <linux/highmem.h>
#include <linux/firmware.h>
-#include "base.h"
#define to_dev(obj) container_of(obj, struct device, kobj)
--
1.6.3.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] firmware_class: remove base.h header inclusion
2010-01-14 2:18 [PATCH] firmware_class: remove base.h header inclusion Luis R. Rodriguez
@ 2010-01-14 5:16 ` Marcel Holtmann
0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2010-01-14 5:16 UTC (permalink / raw)
To: Luis R. Rodriguez
Cc: greg, linux-wireless, linux-kernel, mcgrof, Johannes Berg
Hi Luis,
> base.h is used by base drivers for sharing internal structures.
> Turns out firmware_class does not depend on it at all so remove it.
>
> Cc: Johannes Berg <johannes@sipsolutions.net>
> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Regards
Marcel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-14 5:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-14 2:18 [PATCH] firmware_class: remove base.h header inclusion Luis R. Rodriguez
2010-01-14 5:16 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).