public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Jouni Malinen <j@w1.fi>
Cc: Jouni Malinen <jouni.malinen@atheros.com>,
	"John W. Linville" <linville@tuxdriver.com>,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH] cfg80211/mac80211: Add TX/RX commands for Action frames
Date: Sat, 16 Jan 2010 22:06:59 +0100	[thread overview]
Message-ID: <1263676020.14317.5.camel@johannes.local> (raw)
In-Reply-To: <20100113113000.GA20835@jm.kir.nu>

[-- Attachment #1: Type: text/plain, Size: 1796 bytes --]

On Wed, 2010-01-13 at 13:30 +0200, Jouni Malinen wrote:

> One problem with the registration mechanism is that it may not be
> obvious at this point what exactly we want to export into user space
> in
> the future and what gets handled inside the kernel. One obvious place
> would be to do register to process all Action frames of a specific
> category, but that may not be enough since it is possible that some
> categories will be handled both in kernel and in applications.
> 
> The mechanism for specifying which Action frames are handled will
> likely
> need to be quite extensible.. This would require at least one
> attribute
> for specifying the Category value. Then based on the Category value,
> we
> may need to be able to specify the Action Value as an option
> attribute.
> In addition, the vendor specific Action and Public Action fields would
> need to get OUI as another optional attribute. With vendor specific
> values, we may even need yet another optional attribute to specify the
> subtype of the vendor specific information since some protocols may be
> handled in kernel and some in applications (i.e., more than one
> application for the same vendor OUI).

Ok let me recap what we have
 1) regular action frames -- by category and maybe action subclass
 2) vendor action frames -- category + OUI + vendor-specific stuff
 3) public action (this is a category, can't find a vendor-subclass?)

In all these cases, it would appear to be very easy to handle by just
using the first N bytes. Case 1) would have 1 or two bytes, case 2)
would be 4 or more bytes and case 3) seems like it could be done with 2
or more bytes ...

I've gone ahead and implemented that, will follow up with patches once I
give them some basic testing.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

      parent reply	other threads:[~2010-01-16 21:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-13 10:11 [PATCH] cfg80211/mac80211: Add TX/RX commands for Action frames Jouni Malinen
2010-01-13 10:19 ` Johannes Berg
2010-01-13 11:30   ` Jouni Malinen
2010-01-13 14:53     ` Johannes Berg
2010-01-16 21:06     ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1263676020.14317.5.camel@johannes.local \
    --to=johannes@sipsolutions.net \
    --cc=j@w1.fi \
    --cc=jouni.malinen@atheros.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox