From: Johannes Berg <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <mcgrof@bombadil.infradead.org>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: RFC/RFT: compat-wireless for 2.6.32.4 - MQ backport support
Date: Thu, 21 Jan 2010 10:44:29 +0100 [thread overview]
Message-ID: <1264067069.11396.33.camel@johannes.local> (raw)
In-Reply-To: <20100121025546.GB8069@bombadil.infradead.org>
[-- Attachment #1: Type: text/plain, Size: 547 bytes --]
On Wed, 2010-01-20 at 21:55 -0500, Luis R. Rodriguez wrote:
> @@ -287,7 +287,13 @@
>
> rcu_read_lock();
> list_for_each_entry_rcu(sdata, &local->interfaces, list)
> +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,27))
> netif_tx_wake_queue(netdev_get_tx_queue(sdata->dev, queue));
> +#elif (LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,23))
> + netif_start_subqueue(sdata->dev, queue);
> +#else
> + netif_wake_queue(sdata->dev);
> +#endif
That's incorrect, you need to check for all hardware queues being awake.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2010-01-21 9:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 2:55 RFC/RFT: compat-wireless for 2.6.32.4 - MQ backport support Luis R. Rodriguez
2010-01-21 9:44 ` Johannes Berg [this message]
2010-01-21 18:16 ` Luis R. Rodriguez
2010-01-21 18:38 ` Johannes Berg
2010-01-21 18:56 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264067069.11396.33.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@bombadil.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox