From: Johannes Berg <johannes@sipsolutions.net>
To: pat-lkml@erley.org
Cc: "Luis R. Rodriguez" <mcgrof@bombadil.infradead.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
lrodriguez@atheros.com
Subject: Re: [RFC/RFT v2]: compat-wireless for 2.6.32.4 - multiqueue backport support
Date: Fri, 22 Jan 2010 15:27:54 +0100 [thread overview]
Message-ID: <1264170474.11396.86.camel@johannes.local> (raw)
In-Reply-To: <76acc753e1ea73bdffe1a9772f58bba2@127.0.0.1>
[-- Attachment #1: Type: text/plain, Size: 943 bytes --]
On Fri, 2010-01-22 at 09:14 -0500, pat-lkml@erley.org wrote:
> On Fri, 22 Jan 2010 10:34:38 +0100, Johannes Berg
> <johannes@sipsolutions.net> wrote:
> > On Thu, 2010-01-21 at 18:06 -0500, Luis R. Rodriguez wrote:
> >
> >> +#if (LINUX_VERSION_CODE < KERNEL_VERSION(2,6,23))
> >> +static bool ieee80211_all_queues_stopped(struct ieee80211_hw *hw)
> >
> > You want "all queues started" :)
> >
> Are you certain of this? I stared and stared trying to see what case
> the function would behave as a "started" check. It loops through all
> queues, returning false if it finds any started queues. If it makes
> it through all the queues and hasn't found a single started queue, it
> returns true (to indicate all queues are stopped).
>
> Or do you mean, as a second function?
No, I mean instead. The function is named correctly for what it does,
but it does the wrong thing for the logic where it is used.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2010-01-22 14:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 23:06 [RFC/RFT v2]: compat-wireless for 2.6.32.4 - multiqueue backport support Luis R. Rodriguez
2010-01-22 9:34 ` Johannes Berg
2010-01-22 14:14 ` pat-lkml
2010-01-22 14:27 ` Johannes Berg [this message]
2010-01-22 15:12 ` pat-lkml
2010-01-23 0:09 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264170474.11396.86.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
--cc=mcgrof@bombadil.infradead.org \
--cc=pat-lkml@erley.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox