Re: mac80211: Breakage in software encryption (iwl3945)

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 997 bytes --]

Maxim,

Your mail is confusing me.

On Sat, 2010-01-23 at 22:10 +0200, Maxim Levitsky wrote:
> I updated the kernel and lost connection to my WPA2
> AP. Strangely the WPA handshake completes, but DHCP not.

What did you upgrade to?

> I also unfortunately found that all that time I was using software
> encryption (this is iwl3945 loaded with swcrypto=1).
> Hardware encryption doesn't work ether and didn't work in the slightly
> older kernel (but it did work once, I sure)

That must be a different problem, surely?

> Now, the commit a6bae9e7ab19876a157c91019852395539e4f20e breaks software
> encryption, with behaviour like described above.

And how did you arrive at that conclusion? Have you reverted the patch
and it works again? I really don't see how this particular patch could
break it since afaict it's entirely correct, there are exactly two tests
for IEEE80211_TX_INTFL_DONT_ENCRYPT in mac80211, both of which execute
before the code I removed.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]