From: "Rafał Miłecki" <zajec5@gmail.com>
To: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>
Cc: bcm43xx-dev@lists.berlios.de, "Rafał Miłecki" <zajec5@gmail.com>
Subject: [PATCH 1/4] b43: N-PHY: fix one bit off in parsing RF Ctrl Override arguments
Date: Mon, 25 Jan 2010 18:59:58 +0100 [thread overview]
Message-ID: <1264442401-6364-2-git-send-email-zajec5@gmail.com> (raw)
In-Reply-To: <1264442401-6364-1-git-send-email-zajec5@gmail.com>
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
drivers/net/wireless/b43/phy_n.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/b43/phy_n.c b/drivers/net/wireless/b43/phy_n.c
index a45a1f3..061b01b 100644
--- a/drivers/net/wireless/b43/phy_n.c
+++ b/drivers/net/wireless/b43/phy_n.c
@@ -1031,7 +1031,7 @@ static void b43_nphy_rf_control_override(struct b43_wldev *dev, u16 field,
u8 index = fls(field);
u8 addr, en_addr, val_addr;
/* we expect only one bit set */
- B43_WARN_ON(field & (~(1 << index)));
+ B43_WARN_ON(field & (~(1 << (index - 1))));
if (dev->phy.rev >= 3) {
const struct nphy_rf_control_override_rev3 *rf_ctrl;
--
1.6.4.2
next prev parent reply other threads:[~2010-01-25 18:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-25 17:59 [PATCH 0/4] more N-PHY, cordic stuff Rafał Miłecki
2010-01-25 17:59 ` Rafał Miłecki [this message]
2010-01-25 17:59 ` [PATCH 2/4] b43: make cordic common (LP-PHY and N-PHY need it) Rafał Miłecki
2010-01-25 18:32 ` Michael Buesch
2010-01-25 18:35 ` Rafał Miłecki
2010-01-25 18:36 ` Rafał Miłecki
2010-01-25 18:53 ` Michael Buesch
2010-01-25 22:19 ` John W. Linville
2010-01-25 23:17 ` Rafał Miłecki
2010-01-25 18:00 ` [PATCH 3/4] b43: update cordic code to match current specs Rafał Miłecki
2010-01-25 18:00 ` [PATCH 4/4] b43: N-PHY: use cordic to generate samples Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264442401-6364-2-git-send-email-zajec5@gmail.com \
--to=zajec5@gmail.com \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).