From: Pavel Roskin <proski@gnu.org>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath9k: fix access to freed data on unload
Date: Mon, 01 Feb 2010 16:59:01 -0500 [thread overview]
Message-ID: <1265061541.17261.8.camel@mj> (raw)
In-Reply-To: <43e72e891002011332g5ee05addp3f140ea23a45e09d@mail.gmail.com>
On Mon, 2010-02-01 at 13:32 -0800, Luis R. Rodriguez wrote:
> >> Thanks, can you please resend with a Cc: stable@kernel.org on the commit log?
> >
> > Doesn't look to me like the patch even applies to 2.6.33...?
>
> Sorry thought it would have by then.
The current mainline 2.6.33 uses the cleanup field, but in a different
way. ath_bus_cleanup() is called before ieee80211_free_hw(), so it's
should not be affected by the bug. I was wrong to assume that 2.6.33 is
affected.
As for wireless-testing, once ath_bus_cleanup() moved from main.c to
ahb.c and pci.c, it became redundant (apart from the buggy part).
If we ever want to factorize some cleanup code in the future, it will be
different code anyway, so the current "cleanup" should go away.
--
Regards,
Pavel Roskin
prev parent reply other threads:[~2010-02-01 21:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-31 2:37 [PATCH] ath9k: fix access to freed data on unload Pavel Roskin
2010-02-01 18:11 ` Luis R. Rodriguez
2010-02-01 20:36 ` John W. Linville
2010-02-01 21:32 ` Luis R. Rodriguez
2010-02-01 21:59 ` Pavel Roskin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265061541.17261.8.camel@mj \
--to=proski@gnu.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).