From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga01.intel.com ([192.55.52.88]:27371 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753211Ab0BCBPQ (ORCPT ); Tue, 2 Feb 2010 20:15:16 -0500 Subject: Re: [PATCH 1/1] mac80211: tear down all agg queues when restart/reconfig hw From: "Guy, Wey-Yi" To: Christian Lamparter Cc: "johannes@sipsolutions.net" , "linux-wireless@vger.kernel.org" In-Reply-To: <201002030209.38862.chunkeey@googlemail.com> References: <1265158370-14797-1-git-send-email-wey-yi.w.guy@intel.com> <201002030209.38862.chunkeey@googlemail.com> Content-Type: text/plain Date: Tue, 02 Feb 2010 17:11:47 -0800 Message-Id: <1265159507.15427.0.camel@wwguy-ubuntu> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: Good point, thanks On Tue, 2010-02-02 at 17:09 -0800, Christian Lamparter wrote: > On Wednesday 03 February 2010 01:52:50 wey-yi.w.guy@intel.com wrote: > > From: Wey-Yi Guy > > > > When there is a need to restart/reconfig hw, tear down all the > > aggregation queues and let the mac80211 and driver get in-sync and have > > the opportunity to re-establish the aggregation queues. > > > > Signed-off-by: Wey-Yi Guy > > --- > > net/mac80211/util.c | 5 +++++ > > 1 files changed, 5 insertions(+), 0 deletions(-) > > > > diff --git a/net/mac80211/util.c b/net/mac80211/util.c > > index ca170b4..6116ad0 100644 > > --- a/net/mac80211/util.c > > +++ b/net/mac80211/util.c > > @@ -1188,6 +1188,11 @@ int ieee80211_reconfig(struct ieee80211_local *local) > > ieee80211_wake_queues_by_reason(hw, > > IEEE80211_QUEUE_STOP_REASON_SUSPEND); > > > > + if (hw->flags & IEEE80211_HW_AMPDU_AGGREGATION) { > > + list_for_each_entry_rcu(sta, &local->sta_list, list) { > > + ieee80211_sta_tear_down_BA_sessions(sta); > > + } > > + } > hmm, I somehow miss the rcu_read_lock(); and rcu_read_unlock(); around > list_for_each_entry_rcu... Are you really sure that you don't need > them? > > Regards, > Chr