From: Dan Williams <dcbw@redhat.com>
To: Chris Siebenmann <cks@cs.toronto.edu>
Cc: Stanislaw Gruszka <sgruszka@redhat.com>,
linux-wireless@vger.kernel.org, stable@kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
Chris Siebenmann <cks-rhbugzilla@cs.toronto.edu>
Subject: Re: [PATCH] airo: fix setting zero length WEP key
Date: Thu, 04 Feb 2010 13:44:55 -0800 [thread overview]
Message-ID: <1265319895.4290.4.camel@localhost.localdomain> (raw)
In-Reply-To: <20100203213109.B2D802B0054@apps0.cs.toronto.edu>
On Wed, 2010-02-03 at 16:31 -0500, Chris Siebenmann wrote:
> | > Patch prevents call set_wep_key() with zero key
> | > length. That fix long standing regression since commit
> | > c0380693520b1a1e4f756799a0edc379378b462a "airo: clean up WEP key
> | > operations". [...]
> |
> | What problem/regression does this actually fix? [...]
>
> That mentioned commit broke wireless on a Thinkpad T42 (running Fedora
> 11); from that commit onwards, the wireless system appeared to see no
> networks. The patch makes things work again.
>
> More details are in the Fedora bugzilla:
> https://bugzilla.redhat.com/show_bug.cgi?id=522530
You mean with iwlist? That's quite odd because setting WEP keys doesn't
have anything to do with the scanning stuff, even in the firmware. Note
that Airo has always been somewhat tempermental for scans and you may or
may not see any or all APs in any given scan.
Dan
next prev parent reply other threads:[~2010-02-04 21:45 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-02 14:34 [PATCH] airo: fix setting zero length WEP key Stanislaw Gruszka
2010-02-02 18:32 ` Chris Siebenmann
2010-02-03 20:43 ` Dan Williams
2010-02-03 21:31 ` Chris Siebenmann
2010-02-04 21:44 ` Dan Williams [this message]
2010-02-04 22:10 ` Chris Siebenmann
2010-02-04 22:18 ` Dan Williams
2010-02-04 22:26 ` Chris Siebenmann
2010-02-04 22:39 ` Dan Williams
2010-02-04 22:42 ` Chris Siebenmann
2010-02-04 23:00 ` Dan Williams
2010-02-04 23:03 ` Chris Siebenmann
2010-02-04 23:26 ` Dan Williams
2010-02-04 23:30 ` Dan Williams
2010-02-04 23:36 ` Chris Siebenmann
2010-02-05 6:57 ` Dan Williams
2010-02-04 12:04 ` Stanislaw Gruszka
2010-02-04 12:07 ` [PATCH v2] " Stanislaw Gruszka
2010-02-04 16:41 ` Chris Siebenmann
2010-02-04 23:56 ` Dan Williams
2010-02-05 9:11 ` Stanislaw Gruszka
2010-02-05 6:59 ` Dan Williams
2010-02-05 7:06 ` [PATCH] airo: fix WEP key clearing after c0380693520b1a1e4f756799a0edc379378b462a Dan Williams
2010-02-05 16:26 ` Chris Siebenmann
2010-02-05 19:20 ` Dan Williams
2010-02-05 23:12 ` Chris Siebenmann
2010-02-08 23:47 ` Dan Williams
2010-02-09 16:25 ` Chris Siebenmann
2010-02-09 17:17 ` Chris Siebenmann
2010-02-08 20:55 ` [PATCH v2] airo: fix setting zero length WEP key John W. Linville
2010-02-08 23:44 ` Dan Williams
2010-02-08 20:53 ` John W. Linville
2010-02-09 8:27 ` [PATCH] airo: return from set_wep_key() when key length is zero Stanislaw Gruszka
2010-02-26 14:10 ` [PATCH resend] " Stanislaw Gruszka
2010-02-26 23:09 ` Dan Williams
2010-02-27 1:26 ` John W. Linville
2010-03-01 7:47 ` Stanislaw Gruszka
2010-02-26 23:09 ` [PATCH v2] airo: fix setting zero length WEP key Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265319895.4290.4.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=cks-rhbugzilla@cs.toronto.edu \
--cc=cks@cs.toronto.edu \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=sgruszka@redhat.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).