From: Johannes Berg <johannes@sipsolutions.net>
To: Andrey Yurovsky <andrey@cozybit.com>
Cc: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>,
linux-wireless@vger.kernel.org,
Javier Cardona <javier@cozybit.com>
Subject: Re: [PATCH] nl80211: allow adding new station to devices in mesh mode
Date: Mon, 08 Feb 2010 10:08:09 +0100 [thread overview]
Message-ID: <1265620089.3783.2.camel@johannes.berg> (raw)
In-Reply-To: <c1545bb51002071151wb2cefa3mb03501e0d6b3fb4b@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 768 bytes --]
On Sun, 2010-02-07 at 11:51 -0800, Andrey Yurovsky wrote:
> On Sat, Feb 6, 2010 at 12:59 AM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
> > I do wonder though, the commit (155cc9e4b1d60161ee53) I referenced was
> > yours, and now you're asking the same question as I am -- "why even
> > allow adding stations?"
>
> It was supported for automated testing and experimentation (you could
> then force certain topologies). I can't think of any other reason to
> do it. I suppose that the same thing goes for mpaths and the mesh
> portal tables.
So would you prefer to fix it (however we would do that, I don't think
that the patch here is correct since it leaves the station struct with
no usable rates afaict), or just disallow it?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2010-02-08 13:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-05 1:00 [PATCH] nl80211: allow adding new station to devices in mesh mode Thadeu Lima de Souza Cascardo
2010-02-05 9:39 ` Johannes Berg
2010-02-05 9:59 ` Johannes Berg
2010-02-05 16:57 ` Thadeu Lima de Souza Cascardo
2010-02-05 17:47 ` Andrey Yurovsky
2010-02-05 17:55 ` Thadeu Lima de Souza Cascardo
2010-02-05 19:04 ` Simon Raffeiner
2010-02-05 23:16 ` Andrey Yurovsky
2010-02-06 8:59 ` Johannes Berg
2010-02-07 19:51 ` Andrey Yurovsky
2010-02-08 9:08 ` Johannes Berg [this message]
2010-02-08 19:25 ` Javier Cardona
2010-02-08 20:26 ` Thadeu Lima de Souza Cascardo
2010-02-09 7:58 ` Johannes Berg
2010-02-08 13:54 ` Simon Raffeiner
2010-02-08 17:26 ` Javier Cardona
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265620089.3783.2.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=andrey@cozybit.com \
--cc=cascardo@holoscopio.com \
--cc=javier@cozybit.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox