* [PATCH] iwmc3200wifi: Test of wrong pointer after kzalloc in iwm_mlme_update_bss_table()
@ 2010-02-09 11:07 Roel Kluin
2010-02-09 11:55 ` Samuel Ortiz
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2010-02-09 11:07 UTC (permalink / raw)
To: Samuel Ortiz, Zhu Yi, Intel Linux Wireless, linux-wireless,
Andrew Morton, LKML
The wrong pointer was tested.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
drivers/net/wireless/iwmc3200wifi/rx.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/iwmc3200wifi/rx.c b/drivers/net/wireless/iwmc3200wifi/rx.c
index 6d6ed74..f727b4a 100644
--- a/drivers/net/wireless/iwmc3200wifi/rx.c
+++ b/drivers/net/wireless/iwmc3200wifi/rx.c
@@ -794,7 +794,7 @@ static int iwm_mlme_update_bss_table(struct iwm_priv *iwm, u8 *buf,
}
bss->bss = kzalloc(bss_len, GFP_KERNEL);
- if (!bss) {
+ if (!bss->bss) {
kfree(bss);
IWM_ERR(iwm, "Couldn't allocate bss\n");
return -ENOMEM;
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] iwmc3200wifi: Test of wrong pointer after kzalloc in iwm_mlme_update_bss_table()
2010-02-09 11:07 [PATCH] iwmc3200wifi: Test of wrong pointer after kzalloc in iwm_mlme_update_bss_table() Roel Kluin
@ 2010-02-09 11:55 ` Samuel Ortiz
0 siblings, 0 replies; 2+ messages in thread
From: Samuel Ortiz @ 2010-02-09 11:55 UTC (permalink / raw)
To: Roel Kluin
Cc: Samuel Ortiz, Zhu Yi, Intel Linux Wireless, linux-wireless,
Andrew Morton, LKML
On Tue, 2010-02-09 at 12:07 +0100, Roel Kluin wrote:
> The wrong pointer was tested.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Samuel Ortiz <sameo@linux.intel.com>
> ---
> drivers/net/wireless/iwmc3200wifi/rx.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/iwmc3200wifi/rx.c b/drivers/net/wireless/iwmc3200wifi/rx.c
> index 6d6ed74..f727b4a 100644
> --- a/drivers/net/wireless/iwmc3200wifi/rx.c
> +++ b/drivers/net/wireless/iwmc3200wifi/rx.c
> @@ -794,7 +794,7 @@ static int iwm_mlme_update_bss_table(struct iwm_priv *iwm, u8 *buf,
> }
>
> bss->bss = kzalloc(bss_len, GFP_KERNEL);
> - if (!bss) {
> + if (!bss->bss) {
> kfree(bss);
> IWM_ERR(iwm, "Couldn't allocate bss\n");
> return -ENOMEM;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-09 11:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-09 11:07 [PATCH] iwmc3200wifi: Test of wrong pointer after kzalloc in iwm_mlme_update_bss_table() Roel Kluin
2010-02-09 11:55 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).