From: "Guy, Wey-Yi" <wey-yi.w.guy@intel.com>
To: "Cahill, Ben M" <ben.m.cahill@intel.com>
Cc: "Chatre, Reinette" <reinette.chatre@intel.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ipw3945-devel@lists.sourceforge.net"
<ipw3945-devel@lists.sourceforge.net>
Subject: RE: [ipw3945-devel] [PATCH 05/12] iwlwifi: remove unused op-code in PHY Calibration command
Date: Thu, 11 Feb 2010 12:22:42 -0800 [thread overview]
Message-ID: <1265919762.3119.1.camel@wwguy-ubuntu> (raw)
In-Reply-To: <02B3067C068D0549A8CCFCB17D4D318B626D0610@orsmsx502.amr.corp.intel.com>
Hi Ben,
this is per Giora's request to remove unused calibration command. so we
will not alarm external to play with those commands.
we can add those back in if we are going to use it.
Wey
On Thu, 2010-02-11 at 12:17 -0800, Cahill, Ben M wrote:
> NACK. Keep them around; we may use in the future.
>
> -- Ben --
>
> >-----Original Message-----
> >From: Reinette Chatre [mailto:reinette.chatre@intel.com]
> >Sent: Thursday, February 11, 2010 1:42 PM
> >To: linville@tuxdriver.com
> >Cc: Chatre, Reinette; linux-wireless@vger.kernel.org;
> >ipw3945-devel@lists.sourceforge.net
> >Subject: [ipw3945-devel] [PATCH 05/12] iwlwifi: remove unused
> >op-code in PHY Calibration command
> >
> >From: Wey-Yi Guy <wey-yi.w.guy@intel.com>
> >
> >Number of calibration op-code are not used by driver, remove those from
> >iwl-commands.h
> >
> >Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
> >Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
> >---
> > drivers/net/wireless/iwlwifi/iwl-commands.h | 4 ----
> > 1 files changed, 0 insertions(+), 4 deletions(-)
> >
> >diff --git a/drivers/net/wireless/iwlwifi/iwl-commands.h
> >b/drivers/net/wireless/iwlwifi/iwl-commands.h
> >index c2f31eb..ab3c77b 100644
> >--- a/drivers/net/wireless/iwlwifi/iwl-commands.h
> >+++ b/drivers/net/wireless/iwlwifi/iwl-commands.h
> >@@ -3470,11 +3470,7 @@ enum {
> > IWL_PHY_CALIBRATE_DIFF_GAIN_CMD = 7,
> > IWL_PHY_CALIBRATE_DC_CMD = 8,
> > IWL_PHY_CALIBRATE_LO_CMD = 9,
> >- IWL_PHY_CALIBRATE_RX_BB_CMD = 10,
> > IWL_PHY_CALIBRATE_TX_IQ_CMD = 11,
> >- IWL_PHY_CALIBRATE_RX_IQ_CMD = 12,
> >- IWL_PHY_CALIBRATION_NOISE_CMD = 13,
> >- IWL_PHY_CALIBRATE_AGC_TABLE_CMD = 14,
> > IWL_PHY_CALIBRATE_CRYSTAL_FRQ_CMD = 15,
> > IWL_PHY_CALIBRATE_BASE_BAND_CMD = 16,
> > IWL_PHY_CALIBRATE_TX_IQ_PERD_CMD = 17,
> >--
> >1.6.3.3
> >
> >
> >---------------------------------------------------------------
> >---------------
> >SOLARIS 10 is the OS for Data Centers - provides features such
> >as DTrace,
> >Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
> >http://p.sf.net/sfu/solaris-dev2dev
> >_______________________________________________
> >Ipw3945-devel mailing list
> >Ipw3945-devel@lists.sourceforge.net
> >https://lists.sourceforge.net/lists/listinfo/ipw3945-devel
> >--
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-02-11 20:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-11 18:41 [PATCH 00/12] iwlwifi updates for 2.6.34 Reinette Chatre
2010-02-11 18:41 ` [PATCH 01/12] iwlwifi: clear all tx queues when firmware ready Reinette Chatre
2010-02-11 18:41 ` [PATCH 02/12] iwlwifi: multiple force reset mode Reinette Chatre
2010-02-11 18:41 ` [PATCH 03/12] iwlwifi: add debug function to reset/reload radio/firmware Reinette Chatre
2010-02-11 18:41 ` [PATCH 04/12] iwlwifi: check for aggregation frame and queue Reinette Chatre
2010-02-11 18:41 ` [PATCH 05/12] iwlwifi: remove unused op-code in PHY Calibration command Reinette Chatre
2010-02-11 20:17 ` [ipw3945-devel] " Cahill, Ben M
2010-02-11 20:22 ` Guy, Wey-Yi [this message]
2010-02-11 21:23 ` Cahill, Ben M
2010-02-11 18:41 ` [PATCH 06/12] iwlwifi: cleanup return values Reinette Chatre
2010-02-11 18:42 ` [PATCH 07/12] iwlwifi: fix scan race Reinette Chatre
2010-02-11 18:42 ` [PATCH 08/12] iwlwifi: reset card during probe Reinette Chatre
2010-02-11 18:42 ` [PATCH 09/12] iwlwifi: Adjusting PLCP error threshold for 1000 NIC Reinette Chatre
2010-02-11 18:42 ` [PATCH 10/12] iwlwifi: use dma_alloc_coherent Reinette Chatre
2010-02-11 18:42 ` [PATCH 11/12] iwlwifi: clear all the stop_queue flag after load firmware Reinette Chatre
2010-02-11 18:42 ` [PATCH 12/12] iwlwifi: Monitor and recover the aggregation TX flow failure Reinette Chatre
2010-02-12 13:53 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265919762.3119.1.camel@wwguy-ubuntu \
--to=wey-yi.w.guy@intel.com \
--cc=ben.m.cahill@intel.com \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=reinette.chatre@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).