From: Pavel Roskin <proski@gnu.org>
To: Ivo van Doorn <ivdoorn@gmail.com>
Cc: Gertjan van Wingerde <gwingerde@gmail.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, users@rt2x00.serialmonkey.com
Subject: Re: [PATCH 2/3] rt2x00: Reorganize RT chipset setting for PCI/SOC devices.
Date: Sat, 13 Feb 2010 20:36:15 -0500 [thread overview]
Message-ID: <1266111375.32423.12.camel@mj> (raw)
In-Reply-To: <201002140215.14535.IvDoorn@gmail.com>
On Sun, 2010-02-14 at 02:15 +0100, Ivo van Doorn wrote:
> Hi,
>
> > --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> > +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> > @@ -40,6 +40,9 @@
> > #if defined(CONFIG_RT2X00_LIB_USB) || defined(CONFIG_RT2X00_LIB_USB_MODULE)
> > #include "rt2x00usb.h"
> > #endif
> > +#if defined(CONFIG_RT2X00_LIB_PCI) || defined(CONFIG_RT2X00_LIB_PCI_MODULE)
> > +#include "rt2x00pci.h"
> > +#endif
>
> this is very ugly, but apparently it is unavoidable to make rt2800lib free from
> PCI and USB specific code... :(
I was about to write about a related issue. My kernel configuration
only enables rt2800pci and rt73 drivers. lsmod shows that rt2800lib
depends on rt2x00usb:
# lsmod
Module Size Used by
rt2800pci 9767 0
rt2800lib 24194 1 rt2800pci
rt2x00usb 9474 1 rt2800lib
rt2x00pci 5993 1 rt2800pci
crc_ccitt 1445 1 rt2800pci
rt2x00lib 27776 4 rt2800pci,rt2800lib,rt2x00usb,rt2x00pci
mac80211 215322 3 rt2x00usb,rt2x00pci,rt2x00lib
cfg80211 144471 2 rt2x00lib,mac80211
eeprom_93cx6 1520 1 rt2800pci
To be clear, the above dependency was not introduced by the patch. It
would be nice to straighten it eventually. Maybe the rt2800lib code
should look whether rt2800 (not the generic rt2x00) has USB or PCI
enabled, both for function calls and for includes.
But I'm happy that rt2800pci is working at all! It was my first chance
to test it.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2010-02-14 1:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-13 19:55 [PATCH 0/3] rt2x00: rt2800 detection improvements Gertjan van Wingerde
2010-02-13 19:55 ` [PATCH 1/3] rt2x00: Introduce SoC interface type Gertjan van Wingerde
2010-02-13 19:55 ` [PATCH 2/3] rt2x00: Reorganize RT chipset setting for PCI/SOC devices Gertjan van Wingerde
2010-02-13 19:55 ` [PATCH 3/3] rt2x00: rework RT chipset and revision determination for PCI an SOC devices Gertjan van Wingerde
2010-02-14 1:15 ` Ivo van Doorn
2010-02-14 1:15 ` [PATCH 2/3] rt2x00: Reorganize RT chipset setting for PCI/SOC devices Ivo van Doorn
2010-02-14 1:36 ` Pavel Roskin [this message]
2010-02-14 9:21 ` Gertjan van Wingerde
2010-02-14 1:15 ` [PATCH 1/3] rt2x00: Introduce SoC interface type Ivo van Doorn
2010-02-14 1:37 ` [PATCH 0/3] rt2x00: rt2800 detection improvements Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1266111375.32423.12.camel@mj \
--to=proski@gnu.org \
--cc=gwingerde@gmail.com \
--cc=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox