linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mac80211: fix netdev rename
@ 2010-02-12  9:45 Johannes Berg
  2010-02-15  7:17 ` Pavel Roskin
  0 siblings, 1 reply; 2+ messages in thread
From: Johannes Berg @ 2010-02-12  9:45 UTC (permalink / raw)
  To: John Linville; +Cc: linux-wireless

Fix a copy bug introduced by

    commit 47846c9b0c10808d9337d2e7d09361f3e0a0a71a
    Author: Johannes Berg <johannes@sipsolutions.net>
    Date:   Wed Nov 25 17:46:19 2009 +0100

        mac80211: reduce reliance on netdev

This manifested itself only in debug messages
and in the debugfs rename failure that would
always happen due to trying to rename the dir
over itself.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Cc: stable@kernel.org
---
 net/mac80211/iface.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- wireless-testing.orig/net/mac80211/iface.c	2010-02-12 10:30:17.000000000 +0100
+++ wireless-testing/net/mac80211/iface.c	2010-02-12 10:30:21.000000000 +0100
@@ -1031,7 +1031,7 @@ static int netdev_notify(struct notifier
 
 	sdata = IEEE80211_DEV_TO_SUB_IF(dev);
 
-	memcpy(sdata->name, sdata->name, IFNAMSIZ);
+	memcpy(sdata->name, dev->name, IFNAMSIZ);
 
 	ieee80211_debugfs_rename_netdev(sdata);
 	return 0;



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] mac80211: fix netdev rename
  2010-02-12  9:45 [PATCH] mac80211: fix netdev rename Johannes Berg
@ 2010-02-15  7:17 ` Pavel Roskin
  0 siblings, 0 replies; 2+ messages in thread
From: Pavel Roskin @ 2010-02-15  7:17 UTC (permalink / raw)
  To: Johannes Berg; +Cc: John Linville, linux-wireless

On Fri, 2010-02-12 at 10:45 +0100, Johannes Berg wrote:
> Fix a copy bug introduced by
> 
>     commit 47846c9b0c10808d9337d2e7d09361f3e0a0a71a
>     Author: Johannes Berg <johannes@sipsolutions.net>
>     Date:   Wed Nov 25 17:46:19 2009 +0100
> 
>         mac80211: reduce reliance on netdev
> 
> This manifested itself only in debug messages
> and in the debugfs rename failure that would
> always happen due to trying to rename the dir
> over itself.
> 
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> Cc: stable@kernel.org

Tested-by: Pavel Roskin <proski@gnu.org>

-- 
Regards,
Pavel Roskin

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-02-15  7:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-12  9:45 [PATCH] mac80211: fix netdev rename Johannes Berg
2010-02-15  7:17 ` Pavel Roskin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).