From: Johannes Berg <johannes@sipsolutions.net>
To: Benoit Papillault <benoit.papillault@free.fr>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] mac80211: Improved IBSS merges even if BSSID is the same
Date: Mon, 15 Feb 2010 10:29:38 +0100 [thread overview]
Message-ID: <1266226178.6450.0.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1266190435-2355-2-git-send-email-benoit.papillault@free.fr>
[-- Attachment #1: Type: text/plain, Size: 780 bytes --]
On Mon, 2010-02-15 at 00:33 +0100, Benoit Papillault wrote:
> According to IEEE 802.11, we should merge even if the BSSID from the
> received beacon is the same as our since merge can update more things
> that BSSID itself.
>
> This is specifically true for ath9k where the merge updates TBTT
> timers
> as a side effect and this is indeed needed if the TSF has been updated
> (if TSF is updated, we need to update TBTT timers as well).
>
> However, it could cause continuous merges if the RX timestamp or
> drv_get_tsf() is not accurate or not implemented.
The latter (not implemented) case doesn't actually. I don't just want
you to edit the changelog based on my thoughts, I would prefer if you
actually looked at the code to get your changelog.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2010-02-15 9:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-14 23:33 [PATCH 1/2] mac80211: Improved IBSS merges Benoit Papillault
2010-02-14 23:33 ` [PATCH 2/2] mac80211: Improved IBSS merges even if BSSID is the same Benoit Papillault
2010-02-15 9:28 ` Johannes Berg
2010-02-15 22:24 ` Benoit PAPILLAULT
2010-02-15 9:29 ` Johannes Berg [this message]
2010-02-15 13:40 ` [PATCH 1/2] mac80211: Improved IBSS merges Jouni Malinen
2010-02-15 14:44 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1266226178.6450.0.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=benoit.papillault@free.fr \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).