From: Johannes Berg <johannes@sipsolutions.net>
To: Benoit Papillault <benoit.papillault@free.fr>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] mac80211: Drop protected data frames that have not been decrypted
Date: Tue, 16 Feb 2010 10:58:41 +0100 [thread overview]
Message-ID: <1266314321.4543.0.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1266190653-2453-1-git-send-email-benoit.papillault@free.fr>
[-- Attachment #1: Type: text/plain, Size: 650 bytes --]
On Mon, 2010-02-15 at 00:37 +0100, Benoit Papillault wrote:
> Fix for the following issue : a STA connected to a WPA2 AP was showing
> frames from others STA in tcpdump on wlan0 (promiscuous mode). In
> fact,
> those frames are not decrypted and appears as 802.3 junk. This patch
> just drops any protected data frames that have not been decrypted.
Those frames are only passed up when you set IFF_PROMISC on the
interface, so that's not really a bug, in a sense you wanted to see
them. Now, they may not actually be useful to you, and I'd argue that
checking IFF_PROMISC has no place in mac80211, but it's not really a
bug.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
prev parent reply other threads:[~2010-02-16 9:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-14 23:37 [PATCH 1/2] mac80211: Drop protected data frames that have not been decrypted Benoit Papillault
2010-02-14 23:37 ` [PATCH 2/2] mac80211: Add HT IE to IBSS beacons and probe responses Benoit Papillault
2010-02-15 9:35 ` Johannes Berg
2010-02-15 22:32 ` Benoit PAPILLAULT
2010-02-16 7:17 ` Johannes Berg
2010-02-15 0:10 ` [PATCH 1/2] mac80211: Drop protected data frames that have not been decrypted Gábor Stefanik
2010-02-15 7:45 ` Benoit PAPILLAULT
2010-02-15 9:34 ` Johannes Berg
2010-02-15 22:36 ` Benoit PAPILLAULT
2010-02-16 7:18 ` Johannes Berg
2010-02-15 9:36 ` Johannes Berg
2010-02-16 9:58 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1266314321.4543.0.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=benoit.papillault@free.fr \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).