linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Andres Salomon <dilinger@collabora.co.uk>
Cc: linux-wireless@vger.kernel.org,
	Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [PATCH] mac80211: give warning if building w/out rate ctrl algorithm
Date: Tue, 16 Feb 2010 13:21:19 -0800	[thread overview]
Message-ID: <1266355279.8849.24.camel@localhost.localdomain> (raw)
In-Reply-To: <20100216161656.42079d77@droptest.queued.net>

Hi Andres,

> I discovered that if EMBEDDED=y, one can accidentally build a mac80211 stack
> and drivers w/ no rate control algorithm.  For drivers like RTL8187 that don't
> supply their own RC algorithms, this will cause ieee80211_register_hw to
> fail (making the driver unusable).
> 
> This will tell kconfig to provide a warning if no rate control algorithms
> have been selected.  That'll at least warn the user; users that know that
> their drivers supply a rate control algorithm can safely ignore the
> warning, and those who don't know (or who expect to be using multiple
> drivers) can select a default RC algorithm.

this is not an acceptable policy. You are generating false positives now
for drivers that have been fine before.

Regards

Marcel



  reply	other threads:[~2010-02-16 21:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-16 21:16 [PATCH] mac80211: give warning if building w/out rate ctrl algorithm Andres Salomon
2010-02-16 21:21 ` Marcel Holtmann [this message]
2010-02-16 21:50   ` Andres Salomon
2010-02-16 23:01     ` Marcel Holtmann
2010-02-16 23:43       ` Andres Salomon
2010-02-17  7:40 ` Holger Schurig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1266355279.8849.24.camel@localhost.localdomain \
    --to=marcel@holtmann.org \
    --cc=dilinger@collabora.co.uk \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).