From: Johannes Berg <johannes@sipsolutions.net>
To: reinette chatre <reinette.chatre@intel.com>
Cc: "linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ipw3945-devel@lists.sourceforge.net"
<ipw3945-devel@lists.sourceforge.net>
Subject: Re: [PATCH 2/6] iwlwifi: enable iwl_send_static_wepkey_cmd to sleep
Date: Fri, 19 Feb 2010 18:22:17 +0100 [thread overview]
Message-ID: <1266600137.10689.0.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1266599736.2551.2713.camel@rchatre-DESK>
On Fri, 2010-02-19 at 09:15 -0800, reinette chatre wrote:
> On Fri, 2010-02-19 at 04:59 -0800, Johannes Berg wrote:
> > Or probably better would be this:
> >
> > iwlwifi: change WEP key protection to use mutex
> >
> > Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> > ---
>
> This was a terrible mistake - thank you very much for catching this.
> Your solution looks good.
>
> Acked-by: Reinette Chatre <reinette.chatre@intel.com>
>
> John, could you please replace "iwlwifi: enable
> iwl_send_static_wepkey_cmd to sleep" with "iwlwifi: change WEP key
> protection to use mutex" ?
Not replace though, my patch didn't include the ASYNC->SYNC change. And
it probably wants a better changelog too?
johannes
next prev parent reply other threads:[~2010-02-19 17:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 6:03 [PATCH 0/6] iwlwifi updates for 2.6.34 Reinette Chatre
2010-02-19 6:03 ` [PATCH 1/6] iwl3945: remove STATUS macros from header Reinette Chatre
2010-02-19 6:03 ` [PATCH 2/6] iwlwifi: enable iwl_send_static_wepkey_cmd to sleep Reinette Chatre
2010-02-19 9:13 ` Johannes Berg
2010-02-19 12:59 ` Johannes Berg
2010-02-19 17:15 ` reinette chatre
2010-02-19 17:22 ` Johannes Berg [this message]
2010-02-19 17:30 ` reinette chatre
2010-02-19 6:03 ` [PATCH 3/6] iwlwifi: enable serialization of synchronous commands Reinette Chatre
2010-02-19 6:03 ` [PATCH 4/6] iwlwifi: indicate calib version for 6050 series Reinette Chatre
2010-02-19 6:03 ` [PATCH 5/6] iwlwifi: separated time check for different type of force reset Reinette Chatre
2010-02-19 6:03 ` [PATCH 6/6] iwlwifi: add debugfs to monitor force reset parameters Reinette Chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1266600137.10689.0.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=reinette.chatre@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).