From: Pavel Roskin <proski@gnu.org>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/3] ath5k: remove stale function declarations, make some functions static
Date: Fri, 19 Feb 2010 18:15:25 -0500 [thread overview]
Message-ID: <1266621325.25707.14.camel@mj> (raw)
In-Reply-To: <20100219134448.GA2844@tuxdriver.com>
On Fri, 2010-02-19 at 08:44 -0500, John W. Linville wrote:
> On Thu, Feb 18, 2010 at 08:28:02PM -0500, Pavel Roskin wrote:
> > Remove all unnecessary function declarations from ath5k.h. Comment out
> > unused functions. Remove ath5k_hw_get_tsf32(), which is too trivial to
> > be commented out. Make functions static if suggested by sparse. Make
> > ath5k_pm_ops static.
>
> Any reason not to just remove those functions instead of commenting
> them out?
I'm fine either way. I tend to clean up more aggressively if I know
that nobody will miss that code. I wasn't sure in this case.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2010-02-19 23:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 1:28 [PATCH 1/3] ath5k: remove stale function declarations, make some functions static Pavel Roskin
2010-02-19 1:28 ` [PATCH 2/3] ath5k: remove useless "extern" from function declarations Pavel Roskin
2010-02-19 1:28 ` [PATCH 3/3] ath5k: move ath5k_hw_register_timeout() into reset.c Pavel Roskin
2010-02-19 13:23 ` [PATCH 1/3] ath5k: remove stale function declarations, make some functions static Bob Copeland
2010-02-19 13:44 ` John W. Linville
2010-02-19 23:15 ` Pavel Roskin [this message]
2010-02-20 15:30 ` Bob Copeland
2010-02-23 20:17 ` Pavel Roskin
2010-02-23 20:21 ` John W. Linville
2010-02-23 22:55 ` [ath5k-devel] " Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1266621325.25707.14.camel@mj \
--to=proski@gnu.org \
--cc=ath5k-devel@lists.ath5k.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).