linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Sam Leffler <sleffler@google.com>
Cc: Pavel Roskin <proski@gnu.org>,
	"Luis R. Rodriguez" <mcgrof@gmail.com>,
	Benoit PAPILLAULT <benoit.papillault@free.fr>,
	John Linville <linville@tuxdriver.com>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v3] mac80211: deprecate RX status noise
Date: Sat, 20 Feb 2010 12:06:11 +0100	[thread overview]
Message-ID: <1266663971.10741.1.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <7f9d9abf1002181728q63c9f090je175681bc520f0ad@mail.gmail.com>

On Thu, 2010-02-18 at 17:28 -0800, Sam Leffler wrote: 
> Depends on your definition of channel.  For MIMO devices you can have
> NF per RX chain.

Indeed.

> NF is typically measured infrequently but the frequency is inherently
> hw-specific.

Right.

> Given radiotap is inherently packet-oriented there was little choice
> but to package noise in the way it is.  If you include it only when it
> changes but then you lose the ability to interpret each record
> independently.  Given this value is 8-bits I don't see the big deal.
>  Fixing drivers to include useful data seems more important.

Ah. No, this is not really what I'm debating. For radiotap, we can
include the value in every packet, no matter when it was measured. But
for actual measurement API etc. I think we need to take more care and
not require the driver to fill the status per packet. We can handle
that, for radiotap, in the stack; actually getting noise information out
of the card into userspace _when requested_ should have more of an
up-to-date guarantee (or just not give a value) though, I think. I'd be
happy to make the stack fill radiotap with whatever value we have, but
the way we report it now from the driver to the stack seems completely
bogus.

johannes 



      parent reply	other threads:[~2010-02-20 11:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-17 20:05 [PATCH] mac80211: deprecate RX status noise Johannes Berg
2010-02-17 20:22 ` [PATCH v2] " Johannes Berg
2010-02-17 20:27   ` [PATCH v3] " Johannes Berg
2010-02-17 20:48     ` Benoit PAPILLAULT
2010-02-17 22:29       ` Luis R. Rodriguez
2010-02-17 22:51         ` Pavel Roskin
2010-02-18 12:07           ` Johannes Berg
2010-02-18 14:41             ` Holger Schurig
2010-02-18 14:48               ` Johannes Berg
2010-02-18 19:57                 ` Kalle Valo
2010-02-18 20:27                   ` Luis R. Rodriguez
     [not found]             ` <7f9d9abf1002181728q63c9f090je175681bc520f0ad@mail.gmail.com>
2010-02-20 11:06               ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1266663971.10741.1.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=benoit.papillault@free.fr \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mcgrof@gmail.com \
    --cc=proski@gnu.org \
    --cc=sleffler@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).