linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH V2] ssb: Add PCI ID 0x4322 to PMU handling
@ 2010-02-20 19:49 Larry Finger
  2010-02-21 10:49 ` Rafał Miłecki
  0 siblings, 1 reply; 6+ messages in thread
From: Larry Finger @ 2010-02-20 19:49 UTC (permalink / raw)
  To: John W Linville
  Cc: Michael Buesch, Johannes Berg, bcm43xx-dev, linux-wireless

Some of the N PHYs need a revision in the handling of the PMU.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---

John,

This will be needed for some of the N PHY devices - 2.6.34 amterial.

Larry
---

V2 - Fix typo in subject line of commit message.

Index: wireless-testing/drivers/ssb/driver_chipcommon_pmu.c
===================================================================
--- wireless-testing.orig/drivers/ssb/driver_chipcommon_pmu.c
+++ wireless-testing/drivers/ssb/driver_chipcommon_pmu.c
@@ -332,6 +332,12 @@ static void ssb_pmu_pll_init(struct ssb_
 	case 0x5354:
 		ssb_pmu0_pllinit_r0(cc, crystalfreq);
 		break;
+	case 0x4322:
+		if (cc->pmu.rev == 2) {
+			chipco_write32(cc, SSB_CHIPCO_PLLCTL_ADDR, 0x0000000A);
+			chipco_write32(cc, SSB_CHIPCO_PLLCTL_DATA, 0x380005C0);
+		}
+		break;
 	default:
 		ssb_printk(KERN_ERR PFX
 			   "ERROR: PLL init unknown for device %04X\n",
@@ -417,6 +423,7 @@ static void ssb_pmu_resources_init(struc
 
 	switch (bus->chip_id) {
 	case 0x4312:
+	case 0x4322:
 		/* We keep the default settings:
 		 * min_msk = 0xCBB
 		 * max_msk = 0x7FFFF

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH V2] ssb: Add PCI ID 0x4322 to PMU handling
  2010-02-20 19:49 [PATCH V2] ssb: Add PCI ID 0x4322 to PMU handling Larry Finger
@ 2010-02-21 10:49 ` Rafał Miłecki
  2010-02-21 10:53   ` Gábor Stefanik
  0 siblings, 1 reply; 6+ messages in thread
From: Rafał Miłecki @ 2010-02-21 10:49 UTC (permalink / raw)
  To: Larry Finger
  Cc: John W Linville, Johannes Berg, linux-wireless, bcm43xx-dev,
	Michael Buesch

2010/2/20 Larry Finger <Larry.Finger@lwfinger.net>:
> Some of the N PHYs need a revision in the handling of the PMU.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
>
> John,
>
> This will be needed for some of the N PHY devices - 2.6.34 amterial.
>
> Larry
> ---
>
> V2 - Fix typo in subject line of commit message.

amterial you say? ;)

-- 
Rafał

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH V2] ssb: Add PCI ID 0x4322 to PMU handling
  2010-02-21 10:49 ` Rafał Miłecki
@ 2010-02-21 10:53   ` Gábor Stefanik
  2010-02-21 10:55     ` Johannes Berg
  0 siblings, 1 reply; 6+ messages in thread
From: Gábor Stefanik @ 2010-02-21 10:53 UTC (permalink / raw)
  To: Rafał Miłecki
  Cc: Larry Finger, Johannes Berg, linux-wireless, Michael Buesch,
	bcm43xx-dev

2010/2/21 Rafał Miłecki <zajec5@gmail.com>:
> 2010/2/20 Larry Finger <Larry.Finger@lwfinger.net>:
>> Some of the N PHYs need a revision in the handling of the PMU.
>>
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>> ---
>>
>> John,
>>
>> This will be needed for some of the N PHY devices - 2.6.34 amterial.
>>
>> Larry
>> ---
>>
>> V2 - Fix typo in subject line of commit message.
>
> amterial you say? ;)

Taht's not prat of the cimmot megasse, it is olny a ntoe to Jhon.
Deons't mtater eevn if it is cmolpelety jmulbed up.

>
> --
> Rafał
> _______________________________________________
> Bcm43xx-dev mailing list
> Bcm43xx-dev@lists.berlios.de
> https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
>



-- 
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH V2] ssb: Add PCI ID 0x4322 to PMU handling
  2010-02-21 10:53   ` Gábor Stefanik
@ 2010-02-21 10:55     ` Johannes Berg
  2010-02-21 17:12       ` Larry Finger
  0 siblings, 1 reply; 6+ messages in thread
From: Johannes Berg @ 2010-02-21 10:55 UTC (permalink / raw)
  To: Gábor Stefanik
  Cc: Rafał Miłecki, Larry Finger, linux-wireless,
	Michael Buesch, bcm43xx-dev

[-- Attachment #1: Type: text/plain, Size: 748 bytes --]

On Sun, 2010-02-21 at 11:53 +0100, Gábor Stefanik wrote:
> 2010/2/21 Rafał Miłecki <zajec5@gmail.com>:
> > 2010/2/20 Larry Finger <Larry.Finger@lwfinger.net>:
> >> Some of the N PHYs need a revision in the handling of the PMU.
> >>
> >> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> >> ---
> >>
> >> John,
> >>
> >> This will be needed for some of the N PHY devices - 2.6.34
> amterial.
> >>
> >> Larry
> >> ---
> >>
> >> V2 - Fix typo in subject line of commit message.
> >
> > amterial you say? ;)
> 
> Taht's not prat of the cimmot megasse, it is olny a ntoe to Jhon.
> Deons't mtater eevn if it is cmolpelety jmulbed up.

Geez. The patch is already in the tree anyway, with the original typo.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH V2] ssb: Add PCI ID 0x4322 to PMU handling
  2010-02-21 10:55     ` Johannes Berg
@ 2010-02-21 17:12       ` Larry Finger
  2010-02-22 22:59         ` Rafał Miłecki
  0 siblings, 1 reply; 6+ messages in thread
From: Larry Finger @ 2010-02-21 17:12 UTC (permalink / raw)
  To: Johannes Berg
  Cc: Gábor Stefanik, Rafał Miłecki, linux-wireless,
	Michael Buesch, bcm43xx-dev

On 02/21/2010 04:55 AM, Johannes Berg wrote:
> On Sun, 2010-02-21 at 11:53 +0100, Gábor Stefanik wrote:
>> 2010/2/21 Rafał Miłecki <zajec5@gmail.com>:
>>> 2010/2/20 Larry Finger <Larry.Finger@lwfinger.net>:
>>>> Some of the N PHYs need a revision in the handling of the PMU.
>>>>
>>>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>>>> ---
>>>>
>>>> John,
>>>>
>>>> This will be needed for some of the N PHY devices - 2.6.34
>> amterial.
>>>>
>>>> Larry
>>>> ---
>>>>
>>>> V2 - Fix typo in subject line of commit message.
>>>
>>> amterial you say? ;)
>>
>> Taht's not prat of the cimmot megasse, it is olny a ntoe to Jhon.
>> Deons't mtater eevn if it is cmolpelety jmulbed up.
> 
> Geez. The patch is already in the tree anyway, with the original typo.

I may be getting old and decrepit, but it's OK if the boys just want to have fun
with me.

Larry

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH V2] ssb: Add PCI ID 0x4322 to PMU handling
  2010-02-21 17:12       ` Larry Finger
@ 2010-02-22 22:59         ` Rafał Miłecki
  0 siblings, 0 replies; 6+ messages in thread
From: Rafał Miłecki @ 2010-02-22 22:59 UTC (permalink / raw)
  To: Larry Finger
  Cc: Johannes Berg, Gábor Stefanik, linux-wireless,
	Michael Buesch, bcm43xx-dev

2010/2/21 Larry Finger <Larry.Finger@lwfinger.net>:
> On 02/21/2010 04:55 AM, Johannes Berg wrote:
>> On Sun, 2010-02-21 at 11:53 +0100, Gábor Stefanik wrote:
>>> 2010/2/21 Rafał Miłecki <zajec5@gmail.com>:
>>>> 2010/2/20 Larry Finger <Larry.Finger@lwfinger.net>:
>>>>> Some of the N PHYs need a revision in the handling of the PMU.
>>>>>
>>>>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>>>>> ---
>>>>>
>>>>> John,
>>>>>
>>>>> This will be needed for some of the N PHY devices - 2.6.34
>>> amterial.
>>>>>
>>>>> Larry
>>>>> ---
>>>>>
>>>>> V2 - Fix typo in subject line of commit message.
>>>>
>>>> amterial you say? ;)
>>>
>>> Taht's not prat of the cimmot megasse, it is olny a ntoe to Jhon.
>>> Deons't mtater eevn if it is cmolpelety jmulbed up.
>>
>> Geez. The patch is already in the tree anyway, with the original typo.
>
> I may be getting old and decrepit, but it's OK if the boys just want to have fun
> with me.

And now when typo-ed patch gone git... everyone will see it for ever ;) :P

-- 
Rafał

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2010-02-22 22:59 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-20 19:49 [PATCH V2] ssb: Add PCI ID 0x4322 to PMU handling Larry Finger
2010-02-21 10:49 ` Rafał Miłecki
2010-02-21 10:53   ` Gábor Stefanik
2010-02-21 10:55     ` Johannes Berg
2010-02-21 17:12       ` Larry Finger
2010-02-22 22:59         ` Rafał Miłecki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).