linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	florian@mickler.org, linux-wireless@vger.kernel.org,
	Randy Dunlap <rdunlap@xenotime.net>,
	Alan Jenkins <alan-jenkins@tuffmail.co.uk>,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH 1/2] Document the rfkill sysfs ABI
Date: Mon, 22 Feb 2010 19:16:30 +0100	[thread overview]
Message-ID: <1266862590.18491.37.camel@violet> (raw)
In-Reply-To: <1266851877.23882.67.camel@jlt3.sipsolutions.net>

Hi Johannes,

> > > > > This moves sysfs ABI info from Documentation/rfkill.txt to the
> > > > > ABI subfolder and reformats it.
> > > > > 
> > > > > Signed-off-by: Florian Mickler <florian@mickler.org>
> > > > 
> > > > This is fine with me.
> > > 
> > > we have to be careful here. Some of these sysfs details needs to be
> > > deprecated and removed. Applications should use /dev/rfkill
> > actually.
> > 
> > Maybe all of it should be in "obsolete"?
> 
> Maybe, maybe not. Some people hate /dev/rfkill because it means they
> need to use a programming language (rather than shell scripts), and I
> don't care enough to fight with them.
> 
> For all I care, it can be at the current status quo forever.

I am fine with having these information in sysfs, but then they should
be useful. So we should expose the hard and soft block states and not
some magic madeup state. Also the claim file has to go away.

And not that the rfkill utility is perfect for scripting, but
whatever ;)

Florian, feel free to export the details from /dev/rfkill as proper
sysfs attributes and make them ABI, then we can talk.

Regards

Marcel



  reply	other threads:[~2010-02-22 18:15 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-20 21:40 [PATCH 0/2] Document and enhance rfkill sysfs abi florian
2010-02-20 21:40 ` [PATCH 1/2] Document the rfkill sysfs ABI florian
2010-02-20 22:19   ` Johannes Berg
2010-02-21 10:08     ` Marcel Holtmann
2010-02-21 11:21       ` Florian Mickler
2010-02-22 15:00       ` John W. Linville
2010-02-22 15:17         ` Johannes Berg
2010-02-22 18:16           ` Marcel Holtmann [this message]
2010-02-24 11:05     ` [PATCH v2 0/2] Document and enhance rfkill sysfs abi florian
2010-02-24 11:05     ` [PATCH v2 1/2] Document the rfkill sysfs ABI florian
2010-02-24 11:05     ` [PATCH v2 2/2] enhance sysfs rfkill interface florian
2010-02-25 23:35       ` Henrique de Moraes Holschuh
2010-02-26 11:01         ` florian
2010-02-26 11:01           ` [PATCH v3] " florian
2010-02-26 13:11           ` [PATCH v2 2/2] " Marcel Holtmann
2010-02-26 16:32             ` Florian Mickler
2010-02-20 21:40 ` [PATCH 2/2] enhance /sys/class/rfkill/<rfkill>/state interface florian
2010-02-20 22:14   ` Johannes Berg
2010-02-20 23:07     ` Florian Mickler
2010-02-21 10:07       ` Marcel Holtmann
  -- strict thread matches above, loose matches on Subject: below --
2010-03-12 18:03 [PATCH 0/2] rfkill sysfs ABI florian
2010-03-12 18:03 ` [PATCH 1/2] Document the " florian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1266862590.18491.37.camel@violet \
    --to=marcel@holtmann.org \
    --cc=alan-jenkins@tuffmail.co.uk \
    --cc=florian@mickler.org \
    --cc=gregkh@suse.de \
    --cc=johannes@sipsolutions.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).