From: Marcel Holtmann <marcel@holtmann.org>
To: florian@mickler.org
Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Johannes Berg <johannes@sipsolutions.net>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org,
Randy Dunlap <rdunlap@xenotime.net>,
Alan Jenkins <alan-jenkins@tuffmail.co.uk>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH v2 2/2] enhance sysfs rfkill interface
Date: Fri, 26 Feb 2010 14:11:22 +0100 [thread overview]
Message-ID: <1267189882.18491.63.camel@violet> (raw)
In-Reply-To: <1267182094-15469-1-git-send-email-florian@mickler.org>
Hi Florian,
> > > I am not shure about those names.
> >
> > I don't like them. IMHO, you don't gain anything by being this terse, and
> > it is difficult to understand what they mean at first glance.
> >
> > > Other alternatives:
> > > [hs]w_block
> > > block_[hs]w
> >
>
> I made that blocked_sw and blocked_hw, so that they are
> lexicographically nearby and that they also give more information about
> their content.
>
> blocked_[hs]w -> 0/1 makes IMO kind of sense.
the kernel and /dev/rfkill just talks about "hard" and "soft" blocks.
Don't confuse this with hardware and software. It seems were are keeping
to make this stupid semantical error over and over again. So everything
that says hardware, software, hw or sw in the API is bluntly wrong.
Regards
Marcel
next prev parent reply other threads:[~2010-02-26 13:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-20 21:40 [PATCH 0/2] Document and enhance rfkill sysfs abi florian
2010-02-20 21:40 ` [PATCH 1/2] Document the rfkill sysfs ABI florian
2010-02-20 22:19 ` Johannes Berg
2010-02-21 10:08 ` Marcel Holtmann
2010-02-21 11:21 ` Florian Mickler
2010-02-22 15:00 ` John W. Linville
2010-02-22 15:17 ` Johannes Berg
2010-02-22 18:16 ` Marcel Holtmann
2010-02-24 11:05 ` [PATCH v2 0/2] Document and enhance rfkill sysfs abi florian
2010-02-24 11:05 ` [PATCH v2 1/2] Document the rfkill sysfs ABI florian
2010-02-24 11:05 ` [PATCH v2 2/2] enhance sysfs rfkill interface florian
2010-02-25 23:35 ` Henrique de Moraes Holschuh
2010-02-26 11:01 ` florian
2010-02-26 11:01 ` [PATCH v3] " florian
2010-02-26 13:11 ` Marcel Holtmann [this message]
2010-02-26 16:32 ` [PATCH v2 2/2] " Florian Mickler
2010-02-20 21:40 ` [PATCH 2/2] enhance /sys/class/rfkill/<rfkill>/state interface florian
2010-02-20 22:14 ` Johannes Berg
2010-02-20 23:07 ` Florian Mickler
2010-02-21 10:07 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1267189882.18491.63.camel@violet \
--to=marcel@holtmann.org \
--cc=alan-jenkins@tuffmail.co.uk \
--cc=florian@mickler.org \
--cc=gregkh@suse.de \
--cc=hmh@hmh.eng.br \
--cc=johannes@sipsolutions.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).