From: Zhu Yi <yi.zhu@intel.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] libipw: split ieee->networks into small pieces
Date: Mon, 08 Mar 2010 17:07:11 +0800 [thread overview]
Message-ID: <1268039231.2774.93.camel@debian> (raw)
In-Reply-To: <1268035309.3819.14.camel@jlt3.sipsolutions.net>
On Mon, 2010-03-08 at 16:01 +0800, Johannes Berg wrote:
> On Mon, 2010-03-08 at 13:18 +0800, Zhu Yi wrote:
> > The ieee->networks consists of 128 struct libipw_network entries. If
> > we allocate this chunk of memory altogether, it ends up with an
> > order 4 page allocation. High order page allocation is likely to
> fail
> > on system high load. This patch splits the big chunk memory
> allocation
> > into small pieces, each is 344 bytes, allocates them with 128 times.
> >
> > The patch fixed bug http://bugzilla.kernel.org/show_bug.cgi?id=14989
>
> Could it use cfg80211's scan list stuff and the wext handlers for
> scanning there?
Probably yes. It all depends on how we organize the network list
internally. The ipw firmware sends raw management frames (assoc, beacon,
etc) to driver directly. So We can use cfg80211_bss to track beacons.
But it can require some effort since libipw_network is used throughout
libipw.
Thanks,
-yi
prev parent reply other threads:[~2010-03-08 9:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 5:18 [PATCH] libipw: split ieee->networks into small pieces Zhu Yi
2010-03-08 8:01 ` Johannes Berg
2010-03-08 9:07 ` Zhu Yi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268039231.2774.93.camel@debian \
--to=yi.zhu@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).