From: "Guy, Wey-Yi" <wey-yi.w.guy@intel.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: "Chatre, Reinette" <reinette.chatre@intel.com>,
Greg KH <gregkh@suse.de>, Adel Gadllah <adel.gadllah@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"John W. Linville" <linville@tuxdriver.com>,
"stable@kernel.org" <stable@kernel.org>
Subject: Re: [PATCH 2.6.32] iwlwifi: fix nfreed--
Date: Thu, 18 Mar 2010 08:39:55 -0700 [thread overview]
Message-ID: <1268926795.7892.2.camel@wwguy-ubuntu> (raw)
In-Reply-To: <20100318142933.GB4063@dhcp-lab-161.englab.brq.redhat.com>
Hi Gruszka,
On Thu, 2010-03-18 at 07:29 -0700, Stanislaw Gruszka wrote:
> During backporting of a120e912eb51e347f36c71b60a1d13af74d30e83
> ("iwlwifi: sanity check before counting number of tfds can be free")
> we forget one hunk, what make lot of messages "free more than
> tfds_in_queue" show up in dmesg.
>
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> ---
> drivers/net/wireless/iwlwifi/iwl-tx.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/iwlwifi/iwl-tx.c b/drivers/net/wireless/iwlwifi/iwl-tx.c
> index f449f06..cf5ac00 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-tx.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-tx.c
> @@ -1096,7 +1096,6 @@ int iwl_tx_queue_reclaim(struct iwl_priv *priv, int txq_id, int index)
> priv->cfg->ops->lib->txq_inval_byte_cnt_tbl(priv, txq);
>
> priv->cfg->ops->lib->txq_free_tfd(priv, txq);
> - nfreed++;
> }
> return nfreed;
> }
Thanks for catch this one, it puzzle me a lot because I am using the
latest code and did not realize the "nfreed++" still there in the
backport version.
Wey
next prev parent reply other threads:[~2010-03-18 14:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-14 18:44 [PATCH] iwlwifi: Silence tfds_in_queue message Adel Gadllah
2010-03-16 14:55 ` Stanislaw Gruszka
2010-03-16 15:34 ` Adel Gadllah
2010-03-16 17:00 ` reinette chatre
2010-03-18 14:24 ` Stanislaw Gruszka
2010-03-18 14:29 ` [PATCH 2.6.32] iwlwifi: fix nfreed-- Stanislaw Gruszka
2010-03-18 15:09 ` Adel Gadllah
2010-03-18 15:39 ` Guy, Wey-Yi [this message]
2010-03-18 15:11 ` [PATCH] iwlwifi: Silence tfds_in_queue message Adel Gadllah
2010-03-19 9:22 ` Sedat Dilek
2010-03-19 9:37 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268926795.7892.2.camel@wwguy-ubuntu \
--to=wey-yi.w.guy@intel.com \
--cc=adel.gadllah@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=reinette.chatre@intel.com \
--cc=sgruszka@redhat.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox