[PATCH] iwlwifi: Silence tfds_in_queue message

[PATCH] iwlwifi: Silence tfds_in_queue message

[Adel Gadllah]

>From 83bf3f1dba41e3dccdef4fecfccb094559568342 Mon Sep 17 00:00:00 2001
From: Adel Gadllah <adel.gadllah@gmail.com>
Date: Sun, 14 Mar 2010 19:16:25 +0100
Subject: [PATCH] iwlwifi: Silence tfds_in_queue message

Commit a239a8b47cc0e5e6d7416a89f340beac06d5edaa introduced a
noisy message, that fills up the log very fast.

The error seems not to be fatal (the connection is stable and
performance is ok), so make it IWL_DEBUG_TX rather than IWL_ERR.

Cc: Reinette Chatre <reinette.chatre@intel.com>
Cc: John W. Linville <linville@tuxdriver.com>
Cc: stable@kernel.org

Signed-off-by: Adel Gadllah <adel.gadllah@gmail.com>
---
 drivers/net/wireless/iwlwifi/iwl-tx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/iwlwifi/iwl-tx.c
b/drivers/net/wireless/iwlwifi/iwl-tx.c
index 045e4a6..d6222aa 100644
--- a/drivers/net/wireless/iwlwifi/iwl-tx.c
+++ b/drivers/net/wireless/iwlwifi/iwl-tx.c
@@ -161,7 +161,7 @@ void iwl_free_tfds_in_queue(struct iwl_priv *priv,
 	if (priv->stations[sta_id].tid[tid].tfds_in_queue >= freed)
 		priv->stations[sta_id].tid[tid].tfds_in_queue -= freed;
 	else {
-		IWL_ERR(priv, "free more than tfds_in_queue (%u:%d)\n",
+		IWL_DEBUG_TX(priv, "free more than tfds_in_queue (%u:%d)\n",
 			priv->stations[sta_id].tid[tid].tfds_in_queue,
 			freed);
 		priv->stations[sta_id].tid[tid].tfds_in_queue = 0;
-- 
1.6.6.1

Re: [PATCH] iwlwifi: Silence tfds_in_queue message

[Stanislaw Gruszka]

Hi Adel 

On Sun, Mar 14, 2010 at 07:44:59PM +0100, Adel Gadllah wrote:
> From 83bf3f1dba41e3dccdef4fecfccb094559568342 Mon Sep 17 00:00:00 2001
> From: Adel Gadllah <adel.gadllah@gmail.com>
> Date: Sun, 14 Mar 2010 19:16:25 +0100
> Subject: [PATCH] iwlwifi: Silence tfds_in_queue message
> 
> Commit a239a8b47cc0e5e6d7416a89f340beac06d5edaa introduced a
> noisy message, that fills up the log very fast.
> 
> The error seems not to be fatal (the connection is stable and
> performance is ok), so make it IWL_DEBUG_TX rather than IWL_ERR.

Did you fill a bug report on http://bugzilla.intellinuxwireless.org/
to allow Intel fix the real root of the issue. If not please do.
You may CC me to bug report. 

In general patch looks good for me. 

Cheers
Stanislaw

Re: [PATCH] iwlwifi: Silence tfds_in_queue message

[Adel Gadllah]

2010/3/16 Stanislaw Gruszka <sgruszka@redhat.com>:
> Hi Adel

Hi,

> On Sun, Mar 14, 2010 at 07:44:59PM +0100, Adel Gadllah wrote:
>> From 83bf3f1dba41e3dccdef4fecfccb094559568342 Mon Sep 17 00:00:00 2001
>> From: Adel Gadllah <adel.gadllah@gmail.com>
>> Date: Sun, 14 Mar 2010 19:16:25 +0100
>> Subject: [PATCH] iwlwifi: Silence tfds_in_queue message
>>
>> Commit a239a8b47cc0e5e6d7416a89f340beac06d5edaa introduced a
>> noisy message, that fills up the log very fast.
>>
>> The error seems not to be fatal (the connection is stable and
>> performance is ok), so make it IWL_DEBUG_TX rather than IWL_ERR.
>
> Did you fill a bug report on http://bugzilla.intellinuxwireless.org/
> to allow Intel fix the real root of the issue. If not please do.
> You may CC me to bug report.

Done

> In general patch looks good for me.
>
> Cheers
> Stanislaw
>

Thanks,
Adel

Re: [PATCH] iwlwifi: Silence tfds_in_queue message

[reinette chatre]

On Sun, 2010-03-14 at 11:44 -0700, Adel Gadllah wrote:
> From 83bf3f1dba41e3dccdef4fecfccb094559568342 Mon Sep 17 00:00:00 2001
> From: Adel Gadllah <adel.gadllah@gmail.com>
> Date: Sun, 14 Mar 2010 19:16:25 +0100
> Subject: [PATCH] iwlwifi: Silence tfds_in_queue message
> 
> Commit a239a8b47cc0e5e6d7416a89f340beac06d5edaa introduced a
> noisy message, that fills up the log very fast.
> 
> The error seems not to be fatal (the connection is stable and
> performance is ok), so make it IWL_DEBUG_TX rather than IWL_ERR.
> 
> Cc: Reinette Chatre <reinette.chatre@intel.com>
> Cc: John W. Linville <linville@tuxdriver.com>
> Cc: stable@kernel.org
> 
> Signed-off-by: Adel Gadllah <adel.gadllah@gmail.com>

Acked-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette

Re: [PATCH] iwlwifi: Silence tfds_in_queue message

[Stanislaw Gruszka]

On Tue, Mar 16, 2010 at 10:00:59AM -0700, reinette chatre wrote:
> On Sun, 2010-03-14 at 11:44 -0700, Adel Gadllah wrote:
> > From 83bf3f1dba41e3dccdef4fecfccb094559568342 Mon Sep 17 00:00:00 2001
> > From: Adel Gadllah <adel.gadllah@gmail.com>
> > Date: Sun, 14 Mar 2010 19:16:25 +0100
> > Subject: [PATCH] iwlwifi: Silence tfds_in_queue message
> > 
> > Commit a239a8b47cc0e5e6d7416a89f340beac06d5edaa introduced a
> > noisy message, that fills up the log very fast.
> > 
> > The error seems not to be fatal (the connection is stable and
> > performance is ok), so make it IWL_DEBUG_TX rather than IWL_ERR.
> > 
> > Cc: Reinette Chatre <reinette.chatre@intel.com>
> > Cc: John W. Linville <linville@tuxdriver.com>
> > Cc: stable@kernel.org
> > 
> > Signed-off-by: Adel Gadllah <adel.gadllah@gmail.com>
> 
> Acked-by: Reinette Chatre <reinette.chatre@intel.com>

Actually I would like to NACK the patch.

We did mistake during backporting to 2.6.32 . In iwl_tx_queue_reclaim()
we make make double nfreed--. I don't know how we miss that :(

Greg please take patch from the next email if Adel conform that 
it fix the issue.

Thanks
Stanislaw

[PATCH 2.6.32] iwlwifi: fix nfreed--

[Stanislaw Gruszka]

During backporting of a120e912eb51e347f36c71b60a1d13af74d30e83
("iwlwifi: sanity check before counting number of tfds can be free")
we forget one hunk, what make lot of messages "free more than
tfds_in_queue" show up in dmesg.

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
---
 drivers/net/wireless/iwlwifi/iwl-tx.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/iwlwifi/iwl-tx.c b/drivers/net/wireless/iwlwifi/iwl-tx.c
index f449f06..cf5ac00 100644
--- a/drivers/net/wireless/iwlwifi/iwl-tx.c
+++ b/drivers/net/wireless/iwlwifi/iwl-tx.c
@@ -1096,7 +1096,6 @@ int iwl_tx_queue_reclaim(struct iwl_priv *priv, int txq_id, int index)
 			priv->cfg->ops->lib->txq_inval_byte_cnt_tbl(priv, txq);
 
 		priv->cfg->ops->lib->txq_free_tfd(priv, txq);
-		nfreed++;
 	}
 	return nfreed;
 }
-- 
1.6.2.5

Re: [PATCH 2.6.32] iwlwifi: fix nfreed--

[Adel Gadllah]

2010/3/18 Stanislaw Gruszka <sgruszka@redhat.com>:
> During backporting of a120e912eb51e347f36c71b60a1d13af74d30e83
> ("iwlwifi: sanity check before counting number of tfds can be free")
> we forget one hunk, what make lot of messages "free more than
> tfds_in_queue" show up in dmesg.
>
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>

Good catch, that does indeed fix it.

Tested-by: Adel Gadllah <adel.gadllah@gmail.com>

Re: [PATCH] iwlwifi: Silence tfds_in_queue message

[Adel Gadllah]

2010/3/18 Stanislaw Gruszka <sgruszka@redhat.com>:
> On Tue, Mar 16, 2010 at 10:00:59AM -0700, reinette chatre wrote:
>> On Sun, 2010-03-14 at 11:44 -0700, Adel Gadllah wrote:
>> > From 83bf3f1dba41e3dccdef4fecfccb094559568342 Mon Sep 17 00:00:00 2001
>> > From: Adel Gadllah <adel.gadllah@gmail.com>
>> > Date: Sun, 14 Mar 2010 19:16:25 +0100
>> > Subject: [PATCH] iwlwifi: Silence tfds_in_queue message
>> >
>> > Commit a239a8b47cc0e5e6d7416a89f340beac06d5edaa introduced a
>> > noisy message, that fills up the log very fast.
>> >
>> > The error seems not to be fatal (the connection is stable and
>> > performance is ok), so make it IWL_DEBUG_TX rather than IWL_ERR.
>> >
>> > Cc: Reinette Chatre <reinette.chatre@intel.com>
>> > Cc: John W. Linville <linville@tuxdriver.com>
>> > Cc: stable@kernel.org
>> >
>> > Signed-off-by: Adel Gadllah <adel.gadllah@gmail.com>
>>
>> Acked-by: Reinette Chatre <reinette.chatre@intel.com>
>
> Actually I would like to NACK the patch.
>
> We did mistake during backporting to 2.6.32 . In iwl_tx_queue_reclaim()
> we make make double nfreed--. I don't know how we miss that :(
>
> Greg please take patch from the next email if Adel conform that
> it fix the issue.

Yeah not sure that making it a debug message is a bad idea though (but
even if we want that it doesn't matter much for stable).

Re: [PATCH 2.6.32] iwlwifi: fix nfreed--

[Guy, Wey-Yi]

Hi Gruszka,

On Thu, 2010-03-18 at 07:29 -0700, Stanislaw Gruszka wrote:
> During backporting of a120e912eb51e347f36c71b60a1d13af74d30e83
> ("iwlwifi: sanity check before counting number of tfds can be free")
> we forget one hunk, what make lot of messages "free more than
> tfds_in_queue" show up in dmesg.
> 
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> ---
>  drivers/net/wireless/iwlwifi/iwl-tx.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/wireless/iwlwifi/iwl-tx.c b/drivers/net/wireless/iwlwifi/iwl-tx.c
> index f449f06..cf5ac00 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-tx.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-tx.c
> @@ -1096,7 +1096,6 @@ int iwl_tx_queue_reclaim(struct iwl_priv *priv, int txq_id, int index)
>  			priv->cfg->ops->lib->txq_inval_byte_cnt_tbl(priv, txq);
>  
>  		priv->cfg->ops->lib->txq_free_tfd(priv, txq);
> -		nfreed++;
>  	}
>  	return nfreed;
>  }

Thanks for catch this one, it puzzle me a lot because I am using the
latest code and did not realize the "nfreed++" still there in the
backport version.

Wey

Re: [PATCH] iwlwifi: Silence tfds_in_queue message

[Sedat Dilek]

Hi Stanislaw,

only to clarify:
There is no need for "iwlwifi: Silence tfds_in_queue message" patch
from wireless-2.6 GIT?
I mean "[2.6.32] iwlwifi: fix nfreed--" is enough for solving the
mentionned problem?

Kind Regards,
- Sedat -

On Thu, Mar 18, 2010 at 4:11 PM, Adel Gadllah <adel.gadllah@gmail.com> wrote:
> 2010/3/18 Stanislaw Gruszka <sgruszka@redhat.com>:
>> On Tue, Mar 16, 2010 at 10:00:59AM -0700, reinette chatre wrote:
>>> On Sun, 2010-03-14 at 11:44 -0700, Adel Gadllah wrote:
>>> > From 83bf3f1dba41e3dccdef4fecfccb094559568342 Mon Sep 17 00:00:00 2001
>>> > From: Adel Gadllah <adel.gadllah@gmail.com>
>>> > Date: Sun, 14 Mar 2010 19:16:25 +0100
>>> > Subject: [PATCH] iwlwifi: Silence tfds_in_queue message
>>> >
>>> > Commit a239a8b47cc0e5e6d7416a89f340beac06d5edaa introduced a
>>> > noisy message, that fills up the log very fast.
>>> >
>>> > The error seems not to be fatal (the connection is stable and
>>> > performance is ok), so make it IWL_DEBUG_TX rather than IWL_ERR.
>>> >
>>> > Cc: Reinette Chatre <reinette.chatre@intel.com>
>>> > Cc: John W. Linville <linville@tuxdriver.com>
>>> > Cc: stable@kernel.org
>>> >
>>> > Signed-off-by: Adel Gadllah <adel.gadllah@gmail.com>
>>>
>>> Acked-by: Reinette Chatre <reinette.chatre@intel.com>
>>
>> Actually I would like to NACK the patch.
>>
>> We did mistake during backporting to 2.6.32 . In iwl_tx_queue_reclaim()
>> we make make double nfreed--. I don't know how we miss that :(
>>
>> Greg please take patch from the next email if Adel conform that
>> it fix the issue.
>
> Yeah not sure that making it a debug message is a bad idea though (but
> even if we want that it doesn't matter much for stable).
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: [PATCH] iwlwifi: Silence tfds_in_queue message

[Stanislaw Gruszka]

On Fri, Mar 19, 2010 at 10:22:14AM +0100, Sedat Dilek wrote:
> only to clarify:
> There is no need for "iwlwifi: Silence tfds_in_queue message" patch
> from wireless-2.6 GIT?
>
> I mean "[2.6.32] iwlwifi: fix nfreed--" is enough for solving the
> mentionned problem?

Yes. That was confirmed by Adel.

Cheers
Stanislaw