From: Pavel Roskin <proski@gnu.org>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org,
Richard Kennedy <richard@rsk.demon.co.uk>,
Johannes Berg <johannes@sipsolutions.net>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 7/7] wireless.h: Use SIOCIWFIRST not SIOCSIWCOMMIT for range check
Date: Thu, 18 Mar 2010 13:12:16 -0400 [thread overview]
Message-ID: <1268932336.24544.6.camel@mj> (raw)
In-Reply-To: <b8a4d4b100a03c3f0d82eaeeb8a8e5f2efdd78d9.1268892664.git.joe@perches.com>
On Wed, 2010-03-17 at 23:21 -0700, Joe Perches wrote:
> These two #defines use the same value, but
> SIOCIWFIRST makes more sense in this use.
Agreed. Also please change a comment referring to SIOCSIWCOMMIT in
include/net/iw_handler.h
It would be great if you don't copy LKML next time. It's a purely
wireless issues. I don't like having a dilemma between cross-posting
and trimming the recipient list.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2010-03-18 17:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-18 6:21 [PATCH v2 0/7] wireless: Use macros from wireless.h Joe Perches
2010-03-18 6:21 ` [PATCH v2 1/7] wireless.h: Add STD_IW_HANDLER macro Joe Perches
2010-03-18 17:23 ` Pavel Roskin
2010-03-18 17:37 ` Joe Perches
2010-03-18 6:21 ` [PATCH v2 2/7] net/wireless/wext_core.c: Use IW_IOCTL_IDX macro Joe Perches
2010-03-18 6:21 ` [PATCH v2 3/7] net/wireless/wext-core.c: Use IW_EVENT_IDX macro Joe Perches
2010-03-18 6:21 ` [PATCH v2 4/7] drivers/net/wireless: Use STD_IW_HANDLER macro Joe Perches
2010-03-18 17:25 ` Pavel Roskin
2010-03-18 6:21 ` [PATCH v2 5/7] drivers/net: Remove local #define IW_IOCTL, use STD_IW_HANDLER Joe Perches
2010-03-31 17:55 ` Geoff Levand
2010-03-18 6:21 ` [PATCH v2 6/7] orinoco/wext.c: Remove local #define STD_IW_HANDLER Joe Perches
2010-03-18 6:21 ` [PATCH v2 7/7] wireless.h: Use SIOCIWFIRST not SIOCSIWCOMMIT for range check Joe Perches
2010-03-18 17:12 ` Pavel Roskin [this message]
2010-03-18 17:22 ` [PATCH v2 8/7] iw_handler.h: Use SIOCIWFIRST not SIOCSIWCOMMIT for offset comment Joe Perches
2010-03-18 16:21 ` [PATCH v2 0/7] wireless: Use macros from wireless.h Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268932336.24544.6.camel@mj \
--to=proski@gnu.org \
--cc=joe@perches.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=richard@rsk.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).