Re: iwl3945 and power saving

[reinette chatre <reinette.chatre@intel.com>]

On Fri, 2010-03-19 at 14:41 -0700, Stefan Monnier wrote:
> Aha!  That's very interesting, then.  So, given that the previous naive
> power-saving implementation worked well for me (and I presume other
> users as well), would it be possible to use/provide that old naive
> technique for 3945 and 4965?

We could look into this. Could you please submit a request for this
change to http://bugzilla.intellinuxwireless.org/ ?


> Or does the new technique change too much of the structure of the code
> that the naive technique can't be used any more?
> Could someone kindly point me to the most relevant commits that changed
> the power management technique, if it all possible?

A lot has changed in this area in the last few kernel versions. 

> Would reverting "iwlwifi: unify iwlagn and 3945 power save management"
> be a possible starting point (probably not for a patch that I intend to
> submit back for inclusion, but I'm thinking more for a patch for my own
> personal use, or more likely just to start trying to understand what's
> going on)?

If I remember correctly the patch you refer to only removed duplicated
code.

If there is a need for this then I think what can be done here is either
use the current debugfs "sleep_level_override" or maybe some new one to
get to the old behavior. Currently modifying this value will be ignored
if power saving is marked as broken, as is done for 3945. I wonder if we
can modify it such that user can change this setting even if power
saving is marked as broken. This is maybe something you can try out.

Reinette