linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Juuso Oikarinen <juuso.oikarinen@nokia.com>
Cc: "linville@tuxdriver.com" <linville@tuxdriver.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"Coelho Luciano (Nokia-D/Helsinki)" <Luciano.Coelho@nokia.com>
Subject: Re: [PATCH 2/2] mac80211: Add support for connection quality monitoring
Date: Tue, 23 Mar 2010 05:14:53 -0700	[thread overview]
Message-ID: <1269346493.11714.64.camel@localhost.localdomain> (raw)
In-Reply-To: <1269329862.10120.768.camel@wimaxnb.nmp.nokia.com>

Hi Juuso,

> > > Add support for the set_cqm_config op. This op function configures the
> > > requested connection quality monitor rssi threshold and rssi hysteresis
> > > values to the hardware  if the hardware supports
> > > IEEE80211_HW_SUPPORTS_CQM.
> > > 
> > > For unsupporting hardware, currently -EOPNOTSUPP is returned, so the mac80211
> > > is currently not doing connection quality monitoring on the host. This could be
> > > added later, if needed.
> > 
> > I think you mean "For unsupported hardware, ..." ;)
> 
> I guess you could phrase it like this as well. Do you think this is a
> problem, i.e. do you want me to resubmit a fixed patch?

you can leave this up to John actually. He could also fix this on the
fly when it applies the patch. However if he wants you to re-submit you
might have to do it ;)

Regards

Marcel



  reply	other threads:[~2010-03-23 12:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-23  7:02 [PATCH 0/2] mac80211: cfg80211: Roam trigger support Juuso Oikarinen
2010-03-23  7:02 ` [PATCH 1/2] cfg80211: Add connection quality monitoring support to nl80211 Juuso Oikarinen
2010-03-23 16:23   ` Luis R. Rodriguez
2010-03-24  6:14     ` Juuso Oikarinen
2010-03-24  6:54       ` Luis R. Rodriguez
2010-03-23  7:02 ` [PATCH 2/2] mac80211: Add support for connection quality monitoring Juuso Oikarinen
2010-03-23  7:13   ` Marcel Holtmann
2010-03-23  7:37     ` Juuso Oikarinen
2010-03-23 12:14       ` Marcel Holtmann [this message]
2010-03-23 13:20         ` John W. Linville
2010-03-23 16:21   ` Luis R. Rodriguez
2010-03-25  6:46 ` [PATCH 0/2] mac80211: cfg80211: Roam trigger support Johannes Berg
2010-03-28 19:43   ` Jouni Malinen
2010-03-28 22:48     ` Jouni Malinen
2010-03-29  6:27     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1269346493.11714.64.camel@localhost.localdomain \
    --to=marcel@holtmann.org \
    --cc=Luciano.Coelho@nokia.com \
    --cc=juuso.oikarinen@nokia.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).