From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <linux-wireless-owner@vger.kernel.org>
Received: from he.sipsolutions.net ([78.46.109.217]:52686 "EHLO
	sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751343Ab0CWRT4 (ORCPT
	<rfc822;linux-wireless@vger.kernel.org>);
	Tue, 23 Mar 2010 13:19:56 -0400
Subject: Re: [PATCH 1/2] mac80211: add interface for disabling/enabling QoS
From: Johannes Berg <johannes@sipsolutions.net>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: linux-wireless@vger.kernel.org,
	Reinette Chatre <reinette.chatre@intel.com>,
	"John W. Linville" <linville@tuxdriver.com>
In-Reply-To: <1269348417-4081-1-git-send-email-sgruszka@redhat.com>
References: <1269348417-4081-1-git-send-email-sgruszka@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Date: Tue, 23 Mar 2010 10:19:55 -0700
Message-ID: <1269364795.9689.2.camel@jlt3.sipsolutions.net>
Mime-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org
List-ID: <linux-wireless.vger.kernel.org>

On Tue, 2010-03-23 at 13:46 +0100, Stanislaw Gruszka wrote:

> + * @qos_disabled: whether QoS (aka WMM) should be disabled or not

Why "disabled" btw, and not enabled? Everything else is usually done in
a positive sense here, I'd say.

Also, the default would now be enabled, and I think this needs more work
for AP mode. You're implementing generic API, don't fall into the trap
of thinking it's only for iwlwifi's special case. So at least there it
should be enabled if the hw supports it and the change flag should be
set at least once.

Also, your code sends a weird signal to hw that doesn't support QoS, it
actually enables qos for it ...

johannes