* [PATCH 04/18] mac80211: Generate trace points only if api tracer enabled
[not found] <1269304340-25372-1-git-send-email-jack@suse.cz>
@ 2010-03-23 0:32 ` Jan Kara
2010-03-23 1:11 ` Johannes Berg
0 siblings, 1 reply; 3+ messages in thread
From: Jan Kara @ 2010-03-23 0:32 UTC (permalink / raw)
To: LKML; +Cc: Jan Kara, linux-wireless
CC: linux-wireless@vger.kernel.org
Signed-off-by: Jan Kara <jack@suse.cz>
---
net/mac80211/driver-trace.h | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/net/mac80211/driver-trace.h b/net/mac80211/driver-trace.h
index 41baf73..0e6c059 100644
--- a/net/mac80211/driver-trace.h
+++ b/net/mac80211/driver-trace.h
@@ -1,11 +1,13 @@
#if !defined(__MAC80211_DRIVER_TRACE) || defined(TRACE_HEADER_MULTI_READ)
#define __MAC80211_DRIVER_TRACE
+#undef TRACE_CONFIG
+#define TRACE_CONFIG CONFIG_MAC80211_DRIVER_API_TRACER
#include <linux/tracepoint.h>
#include <net/mac80211.h>
#include "ieee80211_i.h"
-#if !defined(CONFIG_MAC80211_DRIVER_API_TRACER) || defined(__CHECKER__)
+#if defined(__CHECKER__)
#undef TRACE_EVENT
#define TRACE_EVENT(name, proto, ...) \
static inline void trace_ ## name(proto) {}
--
1.6.4.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 04/18] mac80211: Generate trace points only if api tracer enabled
2010-03-23 0:32 ` [PATCH 04/18] mac80211: Generate trace points only if api tracer enabled Jan Kara
@ 2010-03-23 1:11 ` Johannes Berg
2010-03-23 23:54 ` Steven Rostedt
0 siblings, 1 reply; 3+ messages in thread
From: Johannes Berg @ 2010-03-23 1:11 UTC (permalink / raw)
To: Jan Kara; +Cc: LKML, linux-wireless
On Tue, 2010-03-23 at 01:32 +0100, Jan Kara wrote:
> CC: linux-wireless@vger.kernel.org
> Signed-off-by: Jan Kara <jack@suse.cz>
You kinda missed something there, this patch doesn't explain to me why
and it's all I ever got to see :)
johannes
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 04/18] mac80211: Generate trace points only if api tracer enabled
2010-03-23 1:11 ` Johannes Berg
@ 2010-03-23 23:54 ` Steven Rostedt
0 siblings, 0 replies; 3+ messages in thread
From: Steven Rostedt @ 2010-03-23 23:54 UTC (permalink / raw)
To: Johannes Berg; +Cc: Jan Kara, LKML, linux-wireless
On Mon, 2010-03-22 at 18:11 -0700, Johannes Berg wrote:
> On Tue, 2010-03-23 at 01:32 +0100, Jan Kara wrote:
> > CC: linux-wireless@vger.kernel.org
> > Signed-off-by: Jan Kara <jack@suse.cz>
>
> You kinda missed something there, this patch doesn't explain to me why
> and it's all I ever got to see :)
This patch set is about fine grained tuning of what tracepoints get
enabled and which don't. I honestly think that this should only be
permitted if CONFIG_EMBEDDED is set (if it should be permitted at all).
I would much rather find a way to lower the tracepoint footprint than to
pick and choose what tracepoints get enabled.
-- Steve
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-03-23 23:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1269304340-25372-1-git-send-email-jack@suse.cz>
2010-03-23 0:32 ` [PATCH 04/18] mac80211: Generate trace points only if api tracer enabled Jan Kara
2010-03-23 1:11 ` Johannes Berg
2010-03-23 23:54 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).