From: Johannes Berg <johannes@sipsolutions.net>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Zhu Yi <yi.zhu@intel.com>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] mac80211: support paged rx SKBs
Date: Wed, 24 Mar 2010 09:16:02 -0700 [thread overview]
Message-ID: <1269447362.6935.2.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20100324140034.6a6d91c9@dhcp-lab-109.englab.brq.redhat.com>
On Wed, 2010-03-24 at 14:00 +0100, Stanislaw Gruszka wrote:
> On Wed, 24 Mar 2010 10:57:42 +0800
> Zhu Yi <yi.zhu@intel.com> wrote:
>
> > Mac80211 drivers can now pass paged SKBs to mac80211 via
> > ieee80211_rx{_irqsafe}. The implementation currently use
> > skb_linearize() in a few places i.e. management frame handling,
> > software decryption, defragmentation and A-MSDU process.
>
> What benefits this gives? Only driver which need non linear skbs
> is iwliwifi and nicely handle that by itself. I do not see any
> other potential users for that. Can we wait for some other
> users before put that feature into mac stack?
Hell no. We will get more users, and even putting it into the stack now
gives us the benefit of being able to improve it -- iwlwifi doesn't
"nicely" handle it after all.
johannes
next prev parent reply other threads:[~2010-03-24 16:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-24 2:57 [PATCH 1/2] mac80211: support paged rx SKBs Zhu Yi
2010-03-24 2:57 ` [PATCH 2/2] iwlwifi: remove skb_linearize for rx frames Zhu Yi
2010-03-24 5:49 ` [PATCH 1/2] mac80211: support paged rx SKBs Johannes Berg
2010-03-24 13:00 ` Stanislaw Gruszka
2010-03-24 16:16 ` Johannes Berg [this message]
2010-03-25 7:26 ` Stanislaw Gruszka
2010-03-26 3:37 ` Zhu Yi
2010-03-25 6:33 ` Kalle Valo
2010-03-26 3:57 ` Zhu Yi
2010-03-26 6:15 ` Kalle Valo
2010-03-26 8:03 ` Zhu Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269447362.6935.2.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=sgruszka@redhat.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).