From: Johannes Berg <johannes@sipsolutions.net>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: linux-wireless@vger.kernel.org,
Reinette Chatre <reinette.chatre@intel.com>,
"John W. Linville" <linville@tuxdriver.com>,
wey-yi.w.guy@intel.com
Subject: Re: [PATCH 2/2] iwlwifi: manage QoS by mac stack
Date: Fri, 26 Mar 2010 10:28:27 -0700 [thread overview]
Message-ID: <1269624507.4342.4.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1269621992-5034-2-git-send-email-sgruszka@redhat.com>
On Fri, 2010-03-26 at 17:46 +0100, Stanislaw Gruszka wrote:
> --- a/drivers/net/wireless/iwlwifi/iwl-core.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-core.c
> @@ -321,17 +321,13 @@ EXPORT_SYMBOL(iwl_hw_nic_init);
> /*
> * QoS support
> */
> -void iwl_activate_qos(struct iwl_priv *priv, u8 force)
> +void iwl_activate_qos(struct iwl_priv *priv)
I would advocate renaming this function to something like
iwl_update_qos.
Also, since you remove it from 3945/agn, I think it can probably be
static now and lose the export?
johannes
next prev parent reply other threads:[~2010-03-26 17:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-26 16:46 [PATCH 1/2] mac80211: explicitly disable/enable QoS Stanislaw Gruszka
2010-03-26 16:46 ` [PATCH 2/2] iwlwifi: manage QoS by mac stack Stanislaw Gruszka
2010-03-26 17:28 ` Johannes Berg [this message]
2010-03-26 17:48 ` Guy, Wey-Yi
2010-03-26 17:26 ` [PATCH 1/2] mac80211: explicitly disable/enable QoS Johannes Berg
2010-03-29 7:17 ` Stanislaw Gruszka
2010-03-29 8:27 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269624507.4342.4.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=reinette.chatre@intel.com \
--cc=sgruszka@redhat.com \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).